* [2.6 patch] drivers/scsi/NCR_D700.c: fix a NULL dereference
@ 2006-03-10 22:24 Adrian Bunk
0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2006-03-10 22:24 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, linux-kernel
The Coverity checker spotted this NULL dereference.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc5-mm3-full/drivers/scsi/NCR_D700.c.old 2006-03-10 20:25:29.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/drivers/scsi/NCR_D700.c 2006-03-10 20:25:45.000000000 +0100
@@ -206,31 +206,31 @@ NCR_D700_probe_one(struct NCR_D700_priva
if (!host) {
ret = -ENOMEM;
goto detect_failed;
}
p->hosts[siop] = host;
/* FIXME: read this from SUS */
host->this_id = id_array[slot * 2 + siop];
host->irq = irq;
host->base = region;
scsi_scan_host(host);
return 0;
detect_failed:
- release_region(host->base, 64);
+ release_region(region, 64);
region_failed:
kfree(hostdata);
return ret;
}
static int
NCR_D700_intr(int irq, void *data, struct pt_regs *regs)
{
struct NCR_D700_private *p = (struct NCR_D700_private *)data;
int i, found = 0;
for (i = 0; i < 2; i++)
if (p->hosts[i] &&
NCR_700_intr(irq, p->hosts[i], regs) == IRQ_HANDLED)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-03-10 22:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-10 22:24 [2.6 patch] drivers/scsi/NCR_D700.c: fix a NULL dereference Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.