* [2.6 patch] net/sunrpc/clnt.c: fix a NULL pointer dereference
@ 2006-03-10 23:04 Adrian Bunk
0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2006-03-10 23:04 UTC (permalink / raw)
To: neilb, trond.myklebust; +Cc: linux-kernel, nfs
The Coverity checker spotted this possible NULL pointer dereference in
rpc_new_client().
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc5-mm3-full/net/sunrpc/clnt.c.old 2006-03-10 23:39:20.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/net/sunrpc/clnt.c 2006-03-10 23:40:03.000000000 +0100
@@ -112,7 +112,7 @@ rpc_new_client(struct rpc_xprt *xprt, ch
err = -EINVAL;
if (!xprt)
- goto out_err;
+ goto out_no_xprt;
if (vers >= program->nrvers || !(version = program->version[vers]))
goto out_err;
@@ -182,6 +182,7 @@ out_no_path:
kfree(clnt);
out_err:
xprt_destroy(xprt);
+out_no_xprt:
return ERR_PTR(err);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-03-10 23:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-10 23:04 [2.6 patch] net/sunrpc/clnt.c: fix a NULL pointer dereference Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.