From: Olaf Hering <olh@suse.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: enable NAP only on cpus who support it to avoid memory corruption
Date: Sun, 12 Mar 2006 11:40:04 +0100 [thread overview]
Message-ID: <20060312104004.GA26091@suse.de> (raw)
In-Reply-To: <1142121302.4057.52.camel@localhost.localdomain>
On Sun, Mar 12, Benjamin Herrenschmidt wrote:
> On Sat, 2006-03-11 at 22:58 +0100, Olaf Hering wrote:
> > commit 51d3082fe6e55aecfa17113dbe98077c749f724c enabled NAP unconditinally
> > on all powermacs. Early G3 cpus can not use it, the result is memory corruption.
>
> Ok, here is what I think is a proper fix: Just remove the code from
> setup.c since feature.c will already set powersave_nap when needed.
>
> Can you test asap please ? If it fixes the problem for you, I'll send
> the patch to Linus/Andrew with hopes that it will make it in 2.6.16
Yes, this helps.
WARNING: multiple messages have this Message-ID (diff)
From: Olaf Hering <olh@suse.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackeras <paulus@samba.org>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: enable NAP only on cpus who support it to avoid memory corruption
Date: Sun, 12 Mar 2006 11:40:04 +0100 [thread overview]
Message-ID: <20060312104004.GA26091@suse.de> (raw)
In-Reply-To: <1142121302.4057.52.camel@localhost.localdomain>
On Sun, Mar 12, Benjamin Herrenschmidt wrote:
> On Sat, 2006-03-11 at 22:58 +0100, Olaf Hering wrote:
> > commit 51d3082fe6e55aecfa17113dbe98077c749f724c enabled NAP unconditinally
> > on all powermacs. Early G3 cpus can not use it, the result is memory corruption.
>
> Ok, here is what I think is a proper fix: Just remove the code from
> setup.c since feature.c will already set powersave_nap when needed.
>
> Can you test asap please ? If it fixes the problem for you, I'll send
> the patch to Linus/Andrew with hopes that it will make it in 2.6.16
Yes, this helps.
next prev parent reply other threads:[~2006-03-12 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-11 21:58 [PATCH] powerpc: enable NAP only on cpus who support it to avoid memory corruption Olaf Hering
2006-03-11 23:43 ` Benjamin Herrenschmidt
2006-03-11 23:43 ` Benjamin Herrenschmidt
2006-03-11 23:55 ` Benjamin Herrenschmidt
2006-03-11 23:55 ` Benjamin Herrenschmidt
2006-03-12 10:40 ` Olaf Hering [this message]
2006-03-12 10:40 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060312104004.GA26091@suse.de \
--to=olh@suse.de \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.