From: Matthew Wilcox <matthew@wil.cx>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
torvalds@osdl.org, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org, hch@infradead.org,
clameter@sgi.com, jes@sgi.com
Subject: Re: [PATCH] Add SA_PERCPU_IRQ flag support
Date: Mon, 20 Mar 2006 14:22:07 +0000 [thread overview]
Message-ID: <20060320142207.GG8980@parisc-linux.org> (raw)
In-Reply-To: <20060320141747.GA27114@sgi.com>
On Mon, Mar 20, 2006 at 08:17:47AM -0600, Dimitri Sivanich wrote:
> On Sat, Mar 18, 2006 at 01:49:00AM -0800, Andrew Morton wrote:
> > Andrew Morton <akpm@osdl.org> wrote:
> > >
> > > +#ifdef ARCH_HAS_IRQ_PER_CPU
> > > + if (new->flags & SA_PERCPU_IRQ)
> > > + desc->status |= IRQ_PER_CPU;
> > > +#endif
> >
> > OK, five architectures define ARCH_HAS_IRQ_PER_CPU but only one of them
> > defines SA_PERCPU_IRQ. Giving up.
>
> Could we do the following (at least for now)?:
>
> +#if defined(ARCH_HAS_IRQ_PER_CPU) && defined(SA_PERCPU_IRQ)
> + if (new->flags & SA_PERCPU_IRQ)
> + desc->status |= IRQ_PER_CPU;
> +#endif
Why not just
#ifdef SA_PERCPU_IRQ
if (new->flags & SA_PERCPU_IRQ)
desc->status |= IRQ_PER_CPU;
#endif
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
torvalds@osdl.org, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org, hch@infradead.org,
clameter@sgi.com, jes@sgi.com
Subject: Re: [PATCH] Add SA_PERCPU_IRQ flag support
Date: Mon, 20 Mar 2006 07:22:07 -0700 [thread overview]
Message-ID: <20060320142207.GG8980@parisc-linux.org> (raw)
In-Reply-To: <20060320141747.GA27114@sgi.com>
On Mon, Mar 20, 2006 at 08:17:47AM -0600, Dimitri Sivanich wrote:
> On Sat, Mar 18, 2006 at 01:49:00AM -0800, Andrew Morton wrote:
> > Andrew Morton <akpm@osdl.org> wrote:
> > >
> > > +#ifdef ARCH_HAS_IRQ_PER_CPU
> > > + if (new->flags & SA_PERCPU_IRQ)
> > > + desc->status |= IRQ_PER_CPU;
> > > +#endif
> >
> > OK, five architectures define ARCH_HAS_IRQ_PER_CPU but only one of them
> > defines SA_PERCPU_IRQ. Giving up.
>
> Could we do the following (at least for now)?:
>
> +#if defined(ARCH_HAS_IRQ_PER_CPU) && defined(SA_PERCPU_IRQ)
> + if (new->flags & SA_PERCPU_IRQ)
> + desc->status |= IRQ_PER_CPU;
> +#endif
Why not just
#ifdef SA_PERCPU_IRQ
if (new->flags & SA_PERCPU_IRQ)
desc->status |= IRQ_PER_CPU;
#endif
next prev parent reply other threads:[~2006-03-20 14:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 0:31 [PATCH] Add SA_PERCPU_IRQ flag support Dimitri Sivanich
2006-03-17 0:31 ` Dimitri Sivanich
2006-03-17 2:09 ` Christoph Hellwig
2006-03-17 2:09 ` Christoph Hellwig
2006-03-17 23:26 ` Andrew Morton
2006-03-17 23:26 ` Andrew Morton
2006-03-18 9:49 ` Andrew Morton
2006-03-18 9:49 ` Andrew Morton
2006-03-20 14:17 ` Dimitri Sivanich
2006-03-20 14:17 ` Dimitri Sivanich
2006-03-20 14:22 ` Matthew Wilcox [this message]
2006-03-20 14:22 ` Matthew Wilcox
2006-03-20 14:25 ` Dimitri Sivanich
2006-03-20 14:25 ` Dimitri Sivanich
-- strict thread matches above, loose matches on Subject: below --
2006-03-21 21:38 Dimitri Sivanich
2006-03-21 23:37 ` Andrew Morton
2006-03-21 23:45 ` Christoph Lameter
2006-03-22 2:00 ` Benjamin Herrenschmidt
2006-03-22 0:52 ` Dimitri Sivanich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060320142207.GG8980@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=hch@infradead.org \
--cc=jes@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sivanich@sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.