From: Con Kolivas <kernel@kolivas.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux list <linux-kernel@vger.kernel.org>,
ck list <ck@vds.kolivas.org>, Andrew Morton <akpm@osdl.org>,
Pavel Machek <pavel@ucw.cz>,
linux-mm@kvack.org
Subject: Re: [PATCH][3/3] mm: swsusp post resume aggressive swap prefetch
Date: Wed, 22 Mar 2006 17:11:58 +1100 [thread overview]
Message-ID: <200603221711.58390.kernel@kolivas.org> (raw)
In-Reply-To: <200603211911.01829.rjw@sisk.pl>
On Wed, 22 Mar 2006 05:11 am, Rafael J. Wysocki wrote:
> On Tuesday 21 March 2006 01:44, kernel@kolivas.org wrote:
> > Are you looking at swap still in use? Swap prefetch keeps a copy of
> > prefetched pages on backing store as well as in ram so the swap space
> > will not be freed on prefetching.
>
> It looks like I have to debug it a bit more. Unfortunately I've been
> having a lot of work to do recently, so it'll take some time.
No rush whatsoever! I'd just like to help on this.
> > I don't understand what you mean by it won't matter?
>
> Well, sorry. Of course it will matter. What I wanted to say is that in
> this case tbe built-in swsusp would be affected as well as the userland
> suspend, because the hook was in a function used by both.
Understood. So I'll modify it to hook into only built-in swsusp restore when I
get a chance.
Cheers,
Con
WARNING: multiple messages have this Message-ID (diff)
From: Con Kolivas <kernel@kolivas.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux list <linux-kernel@vger.kernel.org>,
ck list <ck@vds.kolivas.org>, Andrew Morton <akpm@osdl.org>,
Pavel Machek <pavel@ucw.cz>,
linux-mm@kvack.org
Subject: Re: [PATCH][3/3] mm: swsusp post resume aggressive swap prefetch
Date: Wed, 22 Mar 2006 17:11:58 +1100 [thread overview]
Message-ID: <200603221711.58390.kernel@kolivas.org> (raw)
In-Reply-To: <200603211911.01829.rjw@sisk.pl>
On Wed, 22 Mar 2006 05:11 am, Rafael J. Wysocki wrote:
> On Tuesday 21 March 2006 01:44, kernel@kolivas.org wrote:
> > Are you looking at swap still in use? Swap prefetch keeps a copy of
> > prefetched pages on backing store as well as in ram so the swap space
> > will not be freed on prefetching.
>
> It looks like I have to debug it a bit more. Unfortunately I've been
> having a lot of work to do recently, so it'll take some time.
No rush whatsoever! I'd just like to help on this.
> > I don't understand what you mean by it won't matter?
>
> Well, sorry. Of course it will matter. What I wanted to say is that in
> this case tbe built-in swsusp would be affected as well as the userland
> suspend, because the hook was in a function used by both.
Understood. So I'll modify it to hook into only built-in swsusp restore when I
get a chance.
Cheers,
Con
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-03-22 6:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-19 15:34 [PATCH][3/3] mm: swsusp post resume aggressive swap prefetch Con Kolivas
2006-03-19 15:34 ` Con Kolivas
2006-03-20 21:47 ` Rafael J. Wysocki
2006-03-20 21:47 ` Rafael J. Wysocki
2006-03-20 21:25 ` kernel
2006-03-20 21:25 ` kernel
2006-03-20 23:22 ` Rafael J. Wysocki
2006-03-20 23:22 ` Rafael J. Wysocki
2006-03-21 0:44 ` kernel
2006-03-21 0:44 ` kernel
2006-03-21 18:11 ` Rafael J. Wysocki
2006-03-21 18:11 ` Rafael J. Wysocki
2006-03-22 6:11 ` Con Kolivas [this message]
2006-03-22 6:11 ` Con Kolivas
2006-03-24 5:00 ` [PATCH] swswsup: return correct load_image error Con Kolivas
2006-03-24 5:00 ` Con Kolivas
2006-03-24 5:17 ` Con Kolivas
2006-03-24 5:17 ` Con Kolivas
2006-03-24 15:05 ` Rafael J. Wysocki
2006-03-24 15:05 ` Rafael J. Wysocki
2006-03-24 14:51 ` Rafael J. Wysocki
2006-03-24 14:51 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603221711.58390.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=ck@vds.kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.