From: Jens Axboe <axboe@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: jejb@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: unify SCSI_IOCTL_SEND_COMMAND implementations
Date: Thu, 23 Mar 2006 11:18:19 +0100 [thread overview]
Message-ID: <20060323101819.GV4285@suse.de> (raw)
In-Reply-To: <20060322165204.GA32287@lst.de>
On Wed, Mar 22 2006, Christoph Hellwig wrote:
> We currently have two implementations of this obsolete ioctl, one in
> the block layer and one in the scsi code. Both of them have drawbacks.
>
> This patch kills the scsi layer version after updating the block version
> with the missing bits:
>
> - argument checking
> - use scatterlist I/O
> - set number of retries based on the submitted command
>
> This is the last user of non-S/G I/O except for the gdth driver, so
> getting this in ASAP and through the scsi tree would be nie to kill
> the non-S/G I/O path. Jens, what do you think about adding a check
> for non-S/G I/O in the midlayer?
Looks good to me. Are cdrom/sr sg clean as well?
--
Jens Axboe
next prev parent reply other threads:[~2006-03-23 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-22 16:52 unify SCSI_IOCTL_SEND_COMMAND implementations Christoph Hellwig
2006-03-23 10:18 ` Jens Axboe [this message]
2006-03-23 14:48 ` Christoph Hellwig
2006-03-23 15:43 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060323101819.GV4285@suse.de \
--to=axboe@suse.de \
--cc=hch@lst.de \
--cc=jejb@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.