From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@suse.de>
Cc: jejb@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: unify SCSI_IOCTL_SEND_COMMAND implementations
Date: Thu, 23 Mar 2006 15:48:00 +0100 [thread overview]
Message-ID: <20060323144800.GA27044@lst.de> (raw)
In-Reply-To: <20060323101819.GV4285@suse.de>
On Thu, Mar 23, 2006 at 11:18:19AM +0100, Jens Axboe wrote:
> > the non-S/G I/O path. Jens, what do you think about adding a check
> > for non-S/G I/O in the midlayer?
>
> Looks good to me. Are cdrom/sr sg clean as well?
there's just one place in cdrom.c that sends a request directly:
cdrom_read_cdda_bpc, which sends a S/G BLOCK_PC one. Everything else
goes through ->packet_command which is implemented as oldstyle-PC
requests in IDE and S/G BLOCK_PC in scsi. all scsi-internal requests
including those from sr are S/G of BLOCK_PC type.
next prev parent reply other threads:[~2006-03-23 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-22 16:52 unify SCSI_IOCTL_SEND_COMMAND implementations Christoph Hellwig
2006-03-23 10:18 ` Jens Axboe
2006-03-23 14:48 ` Christoph Hellwig [this message]
2006-03-23 15:43 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060323144800.GA27044@lst.de \
--to=hch@lst.de \
--cc=axboe@suse.de \
--cc=jejb@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.