From: Adrian Bunk <bunk@stusta.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org,
zhaojignmin@hotmail.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] ip_conntrack_helper_h323.c: EXPORT_SYMBOL'ed functions shouldn't be static
Date: Fri, 24 Mar 2006 01:29:07 +0100 [thread overview]
Message-ID: <20060324002907.GQ22727@stusta.de> (raw)
In-Reply-To: <20060323.161314.59991770.davem@davemloft.net>
On Thu, Mar 23, 2006 at 04:13:14PM -0800, David S. Miller wrote:
> From: Adrian Bunk <bunk@stusta.de>
> Date: Fri, 24 Mar 2006 01:08:01 +0100
>
> > EXPORT_SYMBOL'ed functions shouldn't be static.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> Fixed in Linus's tree as of yesterday.
Sorry for missing this, this must have been after Andrew pulled Linus'
tree for creating 2.6.16-mm1 (which is where I was looking at).
> I actually have a patch from Patrick McHardy that will make
> this kind of error a build time failure instead of silently
> working in the modular case. I just need to test it out
> a bit before pushing.
Yes, it would be nice if it would also fail in CONFIG_MODULES=y builds.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: zhaojignmin@hotmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org
Subject: Re: [2.6 patch] ip_conntrack_helper_h323.c: EXPORT_SYMBOL'ed functions shouldn't be static
Date: Fri, 24 Mar 2006 01:29:07 +0100 [thread overview]
Message-ID: <20060324002907.GQ22727@stusta.de> (raw)
In-Reply-To: <20060323.161314.59991770.davem@davemloft.net>
On Thu, Mar 23, 2006 at 04:13:14PM -0800, David S. Miller wrote:
> From: Adrian Bunk <bunk@stusta.de>
> Date: Fri, 24 Mar 2006 01:08:01 +0100
>
> > EXPORT_SYMBOL'ed functions shouldn't be static.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> Fixed in Linus's tree as of yesterday.
Sorry for missing this, this must have been after Andrew pulled Linus'
tree for creating 2.6.16-mm1 (which is where I was looking at).
> I actually have a patch from Patrick McHardy that will make
> this kind of error a build time failure instead of silently
> working in the modular case. I just need to test it out
> a bit before pushing.
Yes, it would be nice if it would also fail in CONFIG_MODULES=y builds.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2006-03-24 0:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 0:08 [2.6 patch] ip_conntrack_helper_h323.c: EXPORT_SYMBOL'ed functions shouldn't be static Adrian Bunk
2006-03-24 0:08 ` Adrian Bunk
2006-03-24 0:13 ` David S. Miller
2006-03-24 0:29 ` Adrian Bunk [this message]
2006-03-24 0:29 ` Adrian Bunk
2006-03-24 1:27 ` Patrick McHardy
2006-03-24 1:27 ` Patrick McHardy
2006-03-24 6:08 ` David S. Miller
2006-03-24 6:08 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060324002907.GQ22727@stusta.de \
--to=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=zhaojignmin@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.