Re: [uml-devel] Re: TLS support - status - need for re-testing

[Jeff Dike <jdike@addtoit.com>]

On Fri, Mar 24, 2006 at 12:44:05AM +0100, Blaisorblade wrote:
> Yes, that is true, but meanwhile give a testing to them, especially
> regression test the new patches. I can't merge new patches in until
> I'm sure they don't cause regressions.

I took a quick look through the patches - here are some comments:

uml-clean-arch_switch -

This chunk is strange:

@@ -141,7 +148,6 @@ static void new_thread_handler(int sig)
 	set_cmdline("(kernel thread)");
 
 	change_sig(SIGUSR1, 1);
-	change_sig(SIGVTALRM, 1);
 	change_sig(SIGPROF, 1);
 	local_irq_enable();
 	if(!run_kernel_thread(fn, arg, &current->thread.exec_buf))

If you're fixing a bug, you should say what it is.  But the original
looks right, since the process has been scheduled and is running on
its kernel stack, so it should be able to take timer interrupts now.

uml-add-tls-support -

copy_thread - OK for now, but we should move the CLONE_TLS bit into
arch code.

arch_ptrace - Do all arches have PTRACE_[GS]ET_THREAD_AREA, maybe move
inside an ifdef PTRACE_GET_THREAD_AREA

Any patches that change new files should be merged into this, I
think.  That basically means that the stack will mostly collapse into
this one patch.  I didn't see any patches which add new bits of
functionality which would make sense standalone.

global-ldt-sem - We should be using mutexes now, not semaphores

detect-2_4-host - is there no more direct way to detect TLS support?

undo-global-ldt-sem - what's so horrible about the global?  it won't
be highly contended, so making a single mutex saves memory from every
ldt.

				Jeff




-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel