From: Dave Jones <davej@redhat.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries
Date: Wed, 29 Mar 2006 17:51:30 -0500 [thread overview]
Message-ID: <20060329225130.GG452@redhat.com> (raw)
In-Reply-To: <1143671955.23392.3.camel@localhost.localdomain>
On Thu, Mar 30, 2006 at 09:39:15AM +1100, Michael Ellerman wrote:
> On Wed, 2006-03-29 at 14:52 -0500, Dave Jones wrote:
> > On Thu, Mar 23, 2006 at 07:14:49AM +0000, Linux Kernel wrote:
> > > commit 1965746bce49ddf001af52c7985e16343c768021
> > > tree d311fce31613545f3430582322d66411566f1863
> > > parent 0941d57aa7034ef7010bd523752c2e3bee569ef1
> > > author Michael Ellerman <michael@ellerman.id.au> Fri, 10 Feb 2006 15:47:36 +1100
> > > committer Paul Mackerras <paulus@samba.org> Fri, 10 Feb 2006 16:52:03 +1100
> > >
> > > [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries
> > >
> > > Currently we have some stuff in firmware.h and kernel/firmware.c that is
> > > #ifdef CONFIG_PPC_PSERIES. Move it all into platforms/pseries.
> >
> > This (or one of the other firmware patches, I've not narrowed it down that close)
> > breaks ppc64 oprofile.
> >
> > modpost now complains with..
> >
> > kernel/arch/powerpc/oprofile/oprofile.ko needs unknown symbol ppc64_firmware_features
>
> Hi Dave,
>
> I'm not sure about that patch, but I think the firmware feature stuff
> has been broken for modules for a while, we weren't exporting
> ppc64_firmware_features anywhere.
It's bizarre that it's only just started complaining about it.
(I get a nice mail from our buildsystem when a kernel package is built with
unresolved symbols), and the 2.6.16.1 kernel happily sails through.
> The fix just got merged in the last day or so:
> http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d0160bf0b3e87032be8e85f80ddd2f18e107b86f
still broken with that diff. (I just tested -git15)
firmware_has_feature() needs fixing up.
Dave
--
http://www.codemonkey.org.uk
prev parent reply other threads:[~2006-03-29 22:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200603230714.k2N7EmH1021685@hera.kernel.org>
2006-03-29 19:52 ` [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries Dave Jones
2006-03-29 22:00 ` Paul Mackerras
2006-03-29 22:07 ` Dave Jones
2006-03-29 22:58 ` Paul Mackerras
2006-03-29 23:11 ` Dave Jones
2006-03-29 22:39 ` Michael Ellerman
2006-03-29 22:51 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060329225130.GG452@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.