From: Dave Jones <davej@redhat.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michael Ellerman <michael@ellerman.id.au>
Subject: Re: [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries
Date: Wed, 29 Mar 2006 17:07:01 -0500 [thread overview]
Message-ID: <20060329220701.GE452@redhat.com> (raw)
In-Reply-To: <17451.866.287446.68155@cargo.ozlabs.ibm.com>
On Thu, Mar 30, 2006 at 09:00:02AM +1100, Paul Mackerras wrote:
> Dave Jones writes:
>
> > This (or one of the other firmware patches, I've not narrowed it down that close)
> > breaks ppc64 oprofile.
> >
> > modpost now complains with..
> >
> > kernel/arch/powerpc/oprofile/oprofile.ko needs unknown symbol ppc64_firmware_features
>
> That got renamed to powerpc_firmware_features. I don't see any
> occurrences of ppc64_firmware_features left anywhere in the tree. Are
> you sure you don't just need to make clean and rebuild?
See firmware_has_feature() in include/asm-powerpc/firmware.h
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-03-29 22:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200603230714.k2N7EmH1021685@hera.kernel.org>
2006-03-29 19:52 ` [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries Dave Jones
2006-03-29 22:00 ` Paul Mackerras
2006-03-29 22:07 ` Dave Jones [this message]
2006-03-29 22:58 ` Paul Mackerras
2006-03-29 23:11 ` Dave Jones
2006-03-29 22:39 ` Michael Ellerman
2006-03-29 22:51 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060329220701.GE452@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.