* Re: [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries [not found] <200603230714.k2N7EmH1021685@hera.kernel.org> @ 2006-03-29 19:52 ` Dave Jones 2006-03-29 22:00 ` Paul Mackerras 2006-03-29 22:39 ` Michael Ellerman 0 siblings, 2 replies; 7+ messages in thread From: Dave Jones @ 2006-03-29 19:52 UTC (permalink / raw) To: Linux Kernel Mailing List; +Cc: Paul Mackerras, Michael Ellerman On Thu, Mar 23, 2006 at 07:14:49AM +0000, Linux Kernel wrote: > commit 1965746bce49ddf001af52c7985e16343c768021 > tree d311fce31613545f3430582322d66411566f1863 > parent 0941d57aa7034ef7010bd523752c2e3bee569ef1 > author Michael Ellerman <michael@ellerman.id.au> Fri, 10 Feb 2006 15:47:36 +1100 > committer Paul Mackerras <paulus@samba.org> Fri, 10 Feb 2006 16:52:03 +1100 > > [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries > > Currently we have some stuff in firmware.h and kernel/firmware.c that is > #ifdef CONFIG_PPC_PSERIES. Move it all into platforms/pseries. This (or one of the other firmware patches, I've not narrowed it down that close) breaks ppc64 oprofile. modpost now complains with.. kernel/arch/powerpc/oprofile/oprofile.ko needs unknown symbol ppc64_firmware_features Dave -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries 2006-03-29 19:52 ` [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries Dave Jones @ 2006-03-29 22:00 ` Paul Mackerras 2006-03-29 22:07 ` Dave Jones 2006-03-29 22:39 ` Michael Ellerman 1 sibling, 1 reply; 7+ messages in thread From: Paul Mackerras @ 2006-03-29 22:00 UTC (permalink / raw) To: Dave Jones; +Cc: Linux Kernel Mailing List, Michael Ellerman Dave Jones writes: > This (or one of the other firmware patches, I've not narrowed it down that close) > breaks ppc64 oprofile. > > modpost now complains with.. > > kernel/arch/powerpc/oprofile/oprofile.ko needs unknown symbol ppc64_firmware_features That got renamed to powerpc_firmware_features. I don't see any occurrences of ppc64_firmware_features left anywhere in the tree. Are you sure you don't just need to make clean and rebuild? Paul. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries 2006-03-29 22:00 ` Paul Mackerras @ 2006-03-29 22:07 ` Dave Jones 2006-03-29 22:58 ` Paul Mackerras 0 siblings, 1 reply; 7+ messages in thread From: Dave Jones @ 2006-03-29 22:07 UTC (permalink / raw) To: Paul Mackerras; +Cc: Linux Kernel Mailing List, Michael Ellerman On Thu, Mar 30, 2006 at 09:00:02AM +1100, Paul Mackerras wrote: > Dave Jones writes: > > > This (or one of the other firmware patches, I've not narrowed it down that close) > > breaks ppc64 oprofile. > > > > modpost now complains with.. > > > > kernel/arch/powerpc/oprofile/oprofile.ko needs unknown symbol ppc64_firmware_features > > That got renamed to powerpc_firmware_features. I don't see any > occurrences of ppc64_firmware_features left anywhere in the tree. Are > you sure you don't just need to make clean and rebuild? See firmware_has_feature() in include/asm-powerpc/firmware.h Dave -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries 2006-03-29 22:07 ` Dave Jones @ 2006-03-29 22:58 ` Paul Mackerras 2006-03-29 23:11 ` Dave Jones 0 siblings, 1 reply; 7+ messages in thread From: Paul Mackerras @ 2006-03-29 22:58 UTC (permalink / raw) To: Dave Jones; +Cc: Linux Kernel Mailing List, Michael Ellerman Dave Jones writes: > See firmware_has_feature() in include/asm-powerpc/firmware.h In my clone of Linus' linux-2.6 tree, it looks like this: #define firmware_has_feature(feature) \ ((FW_FEATURE_ALWAYS & (feature)) || \ (FW_FEATURE_POSSIBLE & powerpc_firmware_features & (feature))) Perhaps you need to do another pull? Paul. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries 2006-03-29 22:58 ` Paul Mackerras @ 2006-03-29 23:11 ` Dave Jones 0 siblings, 0 replies; 7+ messages in thread From: Dave Jones @ 2006-03-29 23:11 UTC (permalink / raw) To: Paul Mackerras; +Cc: Linux Kernel Mailing List, Michael Ellerman On Thu, Mar 30, 2006 at 09:58:01AM +1100, Paul Mackerras wrote: > Dave Jones writes: > > > See firmware_has_feature() in include/asm-powerpc/firmware.h > > In my clone of Linus' linux-2.6 tree, it looks like this: > > #define firmware_has_feature(feature) \ > ((FW_FEATURE_ALWAYS & (feature)) || \ > (FW_FEATURE_POSSIBLE & powerpc_firmware_features & (feature))) > > Perhaps you need to do another pull? Ah, it hadn't made it into a -git release yet. git17 was still busted. I see the commit on the commits-list though, so I'll just twiddle my thumbs until git18 :-) thanks, Dave -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries 2006-03-29 19:52 ` [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries Dave Jones 2006-03-29 22:00 ` Paul Mackerras @ 2006-03-29 22:39 ` Michael Ellerman 2006-03-29 22:51 ` Dave Jones 1 sibling, 1 reply; 7+ messages in thread From: Michael Ellerman @ 2006-03-29 22:39 UTC (permalink / raw) To: Dave Jones; +Cc: Linux Kernel Mailing List, Paul Mackerras [-- Attachment #1: Type: text/plain, Size: 1521 bytes --] On Wed, 2006-03-29 at 14:52 -0500, Dave Jones wrote: > On Thu, Mar 23, 2006 at 07:14:49AM +0000, Linux Kernel wrote: > > commit 1965746bce49ddf001af52c7985e16343c768021 > > tree d311fce31613545f3430582322d66411566f1863 > > parent 0941d57aa7034ef7010bd523752c2e3bee569ef1 > > author Michael Ellerman <michael@ellerman.id.au> Fri, 10 Feb 2006 15:47:36 +1100 > > committer Paul Mackerras <paulus@samba.org> Fri, 10 Feb 2006 16:52:03 +1100 > > > > [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries > > > > Currently we have some stuff in firmware.h and kernel/firmware.c that is > > #ifdef CONFIG_PPC_PSERIES. Move it all into platforms/pseries. > > This (or one of the other firmware patches, I've not narrowed it down that close) > breaks ppc64 oprofile. > > modpost now complains with.. > > kernel/arch/powerpc/oprofile/oprofile.ko needs unknown symbol ppc64_firmware_features Hi Dave, I'm not sure about that patch, but I think the firmware feature stuff has been broken for modules for a while, we weren't exporting ppc64_firmware_features anywhere. The fix just got merged in the last day or so: http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d0160bf0b3e87032be8e85f80ddd2f18e107b86f cheers -- Michael Ellerman IBM OzLabs wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries 2006-03-29 22:39 ` Michael Ellerman @ 2006-03-29 22:51 ` Dave Jones 0 siblings, 0 replies; 7+ messages in thread From: Dave Jones @ 2006-03-29 22:51 UTC (permalink / raw) To: Michael Ellerman; +Cc: Linux Kernel Mailing List, Paul Mackerras On Thu, Mar 30, 2006 at 09:39:15AM +1100, Michael Ellerman wrote: > On Wed, 2006-03-29 at 14:52 -0500, Dave Jones wrote: > > On Thu, Mar 23, 2006 at 07:14:49AM +0000, Linux Kernel wrote: > > > commit 1965746bce49ddf001af52c7985e16343c768021 > > > tree d311fce31613545f3430582322d66411566f1863 > > > parent 0941d57aa7034ef7010bd523752c2e3bee569ef1 > > > author Michael Ellerman <michael@ellerman.id.au> Fri, 10 Feb 2006 15:47:36 +1100 > > > committer Paul Mackerras <paulus@samba.org> Fri, 10 Feb 2006 16:52:03 +1100 > > > > > > [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries > > > > > > Currently we have some stuff in firmware.h and kernel/firmware.c that is > > > #ifdef CONFIG_PPC_PSERIES. Move it all into platforms/pseries. > > > > This (or one of the other firmware patches, I've not narrowed it down that close) > > breaks ppc64 oprofile. > > > > modpost now complains with.. > > > > kernel/arch/powerpc/oprofile/oprofile.ko needs unknown symbol ppc64_firmware_features > > Hi Dave, > > I'm not sure about that patch, but I think the firmware feature stuff > has been broken for modules for a while, we weren't exporting > ppc64_firmware_features anywhere. It's bizarre that it's only just started complaining about it. (I get a nice mail from our buildsystem when a kernel package is built with unresolved symbols), and the 2.6.16.1 kernel happily sails through. > The fix just got merged in the last day or so: > http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d0160bf0b3e87032be8e85f80ddd2f18e107b86f still broken with that diff. (I just tested -git15) firmware_has_feature() needs fixing up. Dave -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2006-03-29 23:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200603230714.k2N7EmH1021685@hera.kernel.org>
2006-03-29 19:52 ` [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries Dave Jones
2006-03-29 22:00 ` Paul Mackerras
2006-03-29 22:07 ` Dave Jones
2006-03-29 22:58 ` Paul Mackerras
2006-03-29 23:11 ` Dave Jones
2006-03-29 22:39 ` Michael Ellerman
2006-03-29 22:51 ` Dave Jones
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.