All of lore.kernel.org
 help / color / mirror / Atom feed
From: Con Kolivas <kernel@kolivas.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	linux list <linux-kernel@vger.kernel.org>,
	ck list <ck@vds.kolivas.org>, Andrew Morton <akpm@osdl.org>,
	Pavel Machek <pavel@ucw.cz>,
	linux-mm@kvack.org
Subject: Re: [PATCH] mm: swsusp shrink_all_memory tweaks
Date: Fri, 31 Mar 2006 06:38:23 +1000	[thread overview]
Message-ID: <200603310638.23873.kernel@kolivas.org> (raw)
In-Reply-To: <200603301912.32204.rjw@sisk.pl>

On Friday 31 March 2006 03:12, Rafael J. Wysocki wrote:
> OK, I have the following observations:

Thanks.
>
> 1) The patch generally causes more memory to be freed during suspend than
> the unpatched code (good).

Yes I know you meant less, that's good.

> 2) However, if more than 50% of RAM is used by application data, it causes
> the swap prefetch to trigger during resume (that's an impression; anyway
> the system swaps in a lot at that time), which takes some time (generally
> it makes resume 5-10s longer on my box).

Is that with this "swsusp shrink_all_memory tweaks" patch alone? It doesn't 
touch swap prefetch.

> 3) The problem with returning zero prematurely has not been entirely
> eliminated.  It's happened for me only once, though.

Probably hard to say, but is the system in any better state after resume has 
completed? That was one of the aims. Also a major part of this patch is a 
cleanup of the hot balance_pgdat function as well, which suspend no longer 
touches with this patch.

Cheers,
Con

WARNING: multiple messages have this Message-ID (diff)
From: Con Kolivas <kernel@kolivas.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	linux list <linux-kernel@vger.kernel.org>,
	ck list <ck@vds.kolivas.org>, Andrew Morton <akpm@osdl.org>,
	Pavel Machek <pavel@ucw.cz>,
	linux-mm@kvack.org
Subject: Re: [PATCH] mm: swsusp shrink_all_memory tweaks
Date: Fri, 31 Mar 2006 06:38:23 +1000	[thread overview]
Message-ID: <200603310638.23873.kernel@kolivas.org> (raw)
In-Reply-To: <200603301912.32204.rjw@sisk.pl>

On Friday 31 March 2006 03:12, Rafael J. Wysocki wrote:
> OK, I have the following observations:

Thanks.
>
> 1) The patch generally causes more memory to be freed during suspend than
> the unpatched code (good).

Yes I know you meant less, that's good.

> 2) However, if more than 50% of RAM is used by application data, it causes
> the swap prefetch to trigger during resume (that's an impression; anyway
> the system swaps in a lot at that time), which takes some time (generally
> it makes resume 5-10s longer on my box).

Is that with this "swsusp shrink_all_memory tweaks" patch alone? It doesn't 
touch swap prefetch.

> 3) The problem with returning zero prematurely has not been entirely
> eliminated.  It's happened for me only once, though.

Probably hard to say, but is the system in any better state after resume has 
completed? That was one of the aims. Also a major part of this patch is a 
cleanup of the hot balance_pgdat function as well, which suspend no longer 
touches with this patch.

Cheers,
Con

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2006-03-30 20:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-19 15:31 [PATCH][1/3] mm: swsusp shrink_all_memory tweaks Con Kolivas
2006-03-19 15:31 ` Con Kolivas
2006-03-20 11:41 ` Nick Piggin
2006-03-20 11:41   ` Nick Piggin
2006-03-20 11:50   ` Con Kolivas
2006-03-20 11:50     ` Con Kolivas
2006-03-20 18:46     ` Rafael J. Wysocki
2006-03-20 18:46       ` Rafael J. Wysocki
2006-03-24  7:07       ` [PATCH] " Con Kolivas
2006-03-24  7:07         ` Con Kolivas
2006-03-24 15:16         ` Rafael J. Wysocki
2006-03-24 15:16           ` Rafael J. Wysocki
2006-03-24 15:30           ` Con Kolivas
2006-03-24 15:30             ` Con Kolivas
2006-03-24 16:14             ` Rafael J. Wysocki
2006-03-24 16:14               ` Rafael J. Wysocki
2006-03-30 17:12               ` Rafael J. Wysocki
2006-03-30 17:12                 ` Rafael J. Wysocki
2006-03-30 18:37                 ` Rafael J. Wysocki
2006-03-30 18:37                   ` Rafael J. Wysocki
2006-03-30 20:38                 ` Con Kolivas [this message]
2006-03-30 20:38                   ` Con Kolivas
2006-03-30 20:57                   ` Rafael J. Wysocki
2006-03-30 20:57                     ` Rafael J. Wysocki
2006-03-27 12:24         ` Pavel Machek
2006-03-27 12:24           ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200603310638.23873.kernel@kolivas.org \
    --to=kernel@kolivas.org \
    --cc=akpm@osdl.org \
    --cc=ck@vds.kolivas.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.