From: Andi Kleen <ak@suse.de>
To: Jes Sorensen <jes@sgi.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [patch] avoid unaligned access when accessing poll stack
Date: Fri, 31 Mar 2006 16:00:19 +0000 [thread overview]
Message-ID: <200603311800.19364.ak@suse.de> (raw)
In-Reply-To: <yq0sloytyj5.fsf@jaguar.mkp.net>
On Friday 31 March 2006 17:38, Jes Sorensen wrote:
> Hi,
>
> Patch 70674f95c0a2ea694d5c39f4e514f538a09be36f
> [PATCH] Optimize select/poll by putting small data sets on the stack
> resulted in the poll stack being 4-byte aligned on 64-bit
> architectures, causing misaligned accesses to elements in the array.
>
> This patch fixes it by declaring the stack in terms of 'long' instead
> of 'char'.
You should do that for poll too then.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: Jes Sorensen <jes@sgi.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [patch] avoid unaligned access when accessing poll stack
Date: Fri, 31 Mar 2006 18:00:19 +0200 [thread overview]
Message-ID: <200603311800.19364.ak@suse.de> (raw)
In-Reply-To: <yq0sloytyj5.fsf@jaguar.mkp.net>
On Friday 31 March 2006 17:38, Jes Sorensen wrote:
> Hi,
>
> Patch 70674f95c0a2ea694d5c39f4e514f538a09be36f
> [PATCH] Optimize select/poll by putting small data sets on the stack
> resulted in the poll stack being 4-byte aligned on 64-bit
> architectures, causing misaligned accesses to elements in the array.
>
> This patch fixes it by declaring the stack in terms of 'long' instead
> of 'char'.
You should do that for poll too then.
-Andi
next prev parent reply other threads:[~2006-03-31 16:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-31 15:38 [patch] avoid unaligned access when accessing poll stack Jes Sorensen
2006-03-31 15:38 ` Jes Sorensen
2006-03-31 16:00 ` Andi Kleen [this message]
2006-03-31 16:00 ` Andi Kleen
2006-03-31 16:18 ` Jes Sorensen
2006-03-31 16:18 ` Jes Sorensen
2006-04-01 2:35 ` Mitchell Blank Jr
2006-04-01 2:35 ` Mitchell Blank Jr
2006-04-01 2:44 ` Andi Kleen
2006-04-01 2:44 ` Andi Kleen
2006-04-01 3:39 ` Mitchell Blank Jr
2006-04-01 3:39 ` Mitchell Blank Jr
2006-03-31 16:37 ` OGAWA Hirofumi
2006-03-31 16:37 ` OGAWA Hirofumi
2006-03-31 16:53 ` Andi Kleen
2006-03-31 16:53 ` Andi Kleen
2006-03-31 17:16 ` OGAWA Hirofumi
2006-03-31 17:16 ` OGAWA Hirofumi
2006-03-31 17:18 ` Andi Kleen
2006-03-31 17:18 ` Andi Kleen
2006-03-31 17:40 ` OGAWA Hirofumi
2006-03-31 17:40 ` OGAWA Hirofumi
2006-03-31 17:19 ` OGAWA Hirofumi
2006-03-31 17:19 ` OGAWA Hirofumi
2006-03-31 18:20 ` Andrew Morton
2006-03-31 18:20 ` Andrew Morton
2006-04-02 14:49 ` Jes Sorensen
2006-04-02 14:49 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603311800.19364.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jes@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.