From: Andi Kleen <ak@suse.de>
To: Paul Jackson <pj@sgi.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, ak@suse.com,
Christoph Lameter <clameter@sgi.com>
Subject: Re: Fw: 2.6.16 crashes when running numastat on p575
Date: Mon, 3 Apr 2006 13:49:02 +0200 [thread overview]
Message-ID: <200604031349.03036.ak@suse.de> (raw)
In-Reply-To: <20060402221513.96f05bdc.pj@sgi.com>
On Monday 03 April 2006 07:15, Paul Jackson wrote:
> - for (cpu = 0; cpu < NR_CPUS; cpu++) {
> + for_each_online_cpu(cpu) {
>
> Idle curiosity -- what keeps a cpu from going offline during
> this scan, and leaving us with the same crash as before?
CPU hotdown uses RCU like techniques to avoid this. Only potential
problem could be on a preemptive kernel, but I hope nobody tries
cpu unplug on such a beast. The later could be probably fixed
with a rcu_read_lock() or somesuch.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: Paul Jackson <pj@sgi.com>
Cc: Christoph Lameter <clameter@sgi.com>,
sonny@burdell.org, ak@suse.com, akpm@osdl.org,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: Fw: 2.6.16 crashes when running numastat on p575
Date: Mon, 3 Apr 2006 13:49:02 +0200 [thread overview]
Message-ID: <200604031349.03036.ak@suse.de> (raw)
In-Reply-To: <20060402221513.96f05bdc.pj@sgi.com>
On Monday 03 April 2006 07:15, Paul Jackson wrote:
> - for (cpu = 0; cpu < NR_CPUS; cpu++) {
> + for_each_online_cpu(cpu) {
>
> Idle curiosity -- what keeps a cpu from going offline during
> this scan, and leaving us with the same crash as before?
CPU hotdown uses RCU like techniques to avoid this. Only potential
problem could be on a preemptive kernel, but I hope nobody tries
cpu unplug on such a beast. The later could be probably fixed
with a rcu_read_lock() or somesuch.
-Andi
next prev parent reply other threads:[~2006-04-03 11:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060402213216.2e61b74e.akpm@osdl.org>
2006-04-03 5:12 ` Fw: 2.6.16 crashes when running numastat on p575 Christoph Lameter
2006-04-03 5:12 ` Christoph Lameter
2006-04-03 5:15 ` Paul Jackson
2006-04-03 5:15 ` Paul Jackson
2006-04-03 5:25 ` Christoph Lameter
2006-04-03 5:25 ` Christoph Lameter
2006-04-03 6:43 ` Paul Jackson
2006-04-03 6:43 ` Paul Jackson
2006-04-03 14:10 ` Nathan Lynch
2006-04-03 14:10 ` Nathan Lynch
2006-04-03 17:42 ` Christoph Lameter
2006-04-03 17:42 ` Christoph Lameter
2006-04-03 18:01 ` Nathan Lynch
2006-04-03 18:01 ` Nathan Lynch
2006-04-03 18:08 ` Christoph Lameter
2006-04-03 18:08 ` Christoph Lameter
2006-04-03 21:18 ` Andrew Morton
2006-04-03 21:18 ` Andrew Morton
2006-04-04 0:25 ` Paul Jackson
2006-04-04 0:25 ` Paul Jackson
2006-04-03 11:49 ` Andi Kleen [this message]
2006-04-03 11:49 ` Andi Kleen
2006-04-03 14:18 ` Nathan Lynch
2006-04-03 14:18 ` Nathan Lynch
2006-04-03 8:09 ` Sonny Rao
2006-04-03 8:09 ` Sonny Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604031349.03036.ak@suse.de \
--to=ak@suse.de \
--cc=ak@suse.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.