* [patch 3/9] s390: invalid check after kzalloc()
@ 2006-04-03 17:21 Martin Schwidefsky
0 siblings, 0 replies; only message in thread
From: Martin Schwidefsky @ 2006-04-03 17:21 UTC (permalink / raw)
To: akpm, peter.oberparleiter, linux-kernel
From: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
[patch 3/9] s390: invalid check after kzalloc()
Typo. After the call to kzalloc() for kdb->key_maps the test
for NULL checks the wrong variable.
Signed-off-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
drivers/s390/char/keyboard.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -urpN linux-2.6/drivers/s390/char/keyboard.c linux-2.6-patched/drivers/s390/char/keyboard.c
--- linux-2.6/drivers/s390/char/keyboard.c 2006-04-03 18:46:20.000000000 +0200
+++ linux-2.6-patched/drivers/s390/char/keyboard.c 2006-04-03 18:46:36.000000000 +0200
@@ -54,7 +54,7 @@ kbd_alloc(void) {
if (!kbd)
goto out;
kbd->key_maps = kzalloc(sizeof(key_maps), GFP_KERNEL);
- if (!key_maps)
+ if (!kbd->key_maps)
goto out_kbd;
for (i = 0; i < ARRAY_SIZE(key_maps); i++) {
if (key_maps[i]) {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-04-03 17:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-03 17:21 [patch 3/9] s390: invalid check after kzalloc() Martin Schwidefsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.