All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ipmi: fix event queue limit
@ 2006-04-08  2:51 Corey Minyard
  0 siblings, 0 replies; only message in thread
From: Corey Minyard @ 2006-04-08  2:51 UTC (permalink / raw)
  To: linux-kernel; +Cc: akpm

The event handler mechanism in the IPMI driver had a limit on the
number of received events, but the counts were not being updated.
Update the counts to impose a limit.  This is not a critical fix,
as this function (the sending of the events) has to be turned on
by the user, anyway.  This avoids problems if they forget to
turn it back off.

Signed-off-by: Corey Minyard <minyard@acm.org>

Index: linux-2.6.16/drivers/char/ipmi/ipmi_msghandler.c
===================================================================
--- linux-2.6.16.orig/drivers/char/ipmi/ipmi_msghandler.c
+++ linux-2.6.16/drivers/char/ipmi/ipmi_msghandler.c
@@ -941,6 +941,7 @@ int ipmi_set_gets_events(ipmi_user_t use
 			list_del(&msg->link);
 			list_add_tail(&msg->link, &msgs);
 		}
+		intf->waiting_events_count = 0;
 	}
 
 	/* Hold the events lock while doing this to preserve order. */
@@ -2917,6 +2918,7 @@ static int handle_read_event_rsp(ipmi_sm
 
 		copy_event_into_recv_msg(recv_msg, msg);
 		list_add_tail(&(recv_msg->link), &(intf->waiting_events));
+		intf->waiting_events_count++;
 	} else {
 		/* There's too many things in the queue, discard this
 		   message. */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-04-08  2:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-08  2:51 [PATCH] ipmi: fix event queue limit Corey Minyard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.