From: Adrian Bunk <bunk@stusta.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
rmk@arm.linux.org.uk
Subject: Re: [RFC: 2.6 patch] let arm use drivers/Kconfig
Date: Thu, 20 Apr 2006 14:06:24 +0200 [thread overview]
Message-ID: <20060420120624.GO25047@stusta.de> (raw)
In-Reply-To: <1145285754.13200.15.camel@pmac.infradead.org>
On Mon, Apr 17, 2006 at 03:55:54PM +0100, David Woodhouse wrote:
> On Mon, 2006-04-17 at 16:48 +0200, Adrian Bunk wrote:
> > --- linux-2.6.17-rc1-mm2-arm/drivers/mtd/Kconfig.old 2006-04-17 14:32:35.000000000 +0200
> > +++ linux-2.6.17-rc1-mm2-arm/drivers/mtd/Kconfig 2006-04-17 15:00:57.000000000 +0200
> > @@ -1,6 +1,7 @@
> > # $Id: Kconfig,v 1.11 2005/11/07 11:14:19 gleixner Exp $
> >
> > menu "Memory Technology Devices (MTD)"
> > + depends on (ALIGNMENT_TRAP || !ARM)
> >
> > config MTD
> > tristate "Memory Technology Device (MTD) support"
>
> This dependency is incorrect. It's only one or two chip-specific drivers
> which require that the architecture correctly handle alignment traps,
> and even then it's only actually apparent when used with JFFS2 which
> actually _gives_ it an unaligned buffer occasionally. Everything else
> works fine.
>
> Also, I don't want to see this dependency expressed in the MTD Kconfig
> file unless it's not arch-specific. Please make a generic
> BROKEN_UNALIGNED config option, and set it on all architectures which
> need it. Then propose a saner place to put the restriction instead of on
> CONFIG_MTD.
Can anyone tell me which chip-specific drivers are affected by this
issue so that I can send a patch?
> dwmw2
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: rmk@arm.linux.org.uk, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [RFC: 2.6 patch] let arm use drivers/Kconfig
Date: Thu, 20 Apr 2006 14:06:24 +0200 [thread overview]
Message-ID: <20060420120624.GO25047@stusta.de> (raw)
In-Reply-To: <1145285754.13200.15.camel@pmac.infradead.org>
On Mon, Apr 17, 2006 at 03:55:54PM +0100, David Woodhouse wrote:
> On Mon, 2006-04-17 at 16:48 +0200, Adrian Bunk wrote:
> > --- linux-2.6.17-rc1-mm2-arm/drivers/mtd/Kconfig.old 2006-04-17 14:32:35.000000000 +0200
> > +++ linux-2.6.17-rc1-mm2-arm/drivers/mtd/Kconfig 2006-04-17 15:00:57.000000000 +0200
> > @@ -1,6 +1,7 @@
> > # $Id: Kconfig,v 1.11 2005/11/07 11:14:19 gleixner Exp $
> >
> > menu "Memory Technology Devices (MTD)"
> > + depends on (ALIGNMENT_TRAP || !ARM)
> >
> > config MTD
> > tristate "Memory Technology Device (MTD) support"
>
> This dependency is incorrect. It's only one or two chip-specific drivers
> which require that the architecture correctly handle alignment traps,
> and even then it's only actually apparent when used with JFFS2 which
> actually _gives_ it an unaligned buffer occasionally. Everything else
> works fine.
>
> Also, I don't want to see this dependency expressed in the MTD Kconfig
> file unless it's not arch-specific. Please make a generic
> BROKEN_UNALIGNED config option, and set it on all architectures which
> need it. Then propose a saner place to put the restriction instead of on
> CONFIG_MTD.
Can anyone tell me which chip-specific drivers are affected by this
issue so that I can send a patch?
> dwmw2
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2006-04-20 12:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-17 14:48 [RFC: 2.6 patch] let arm use drivers/Kconfig Adrian Bunk
2006-04-17 14:48 ` Adrian Bunk
2006-04-17 14:55 ` David Woodhouse
2006-04-17 14:55 ` David Woodhouse
2006-04-20 12:06 ` Adrian Bunk [this message]
2006-04-20 12:06 ` Adrian Bunk
2006-04-20 20:54 ` David Woodhouse
2006-04-20 20:54 ` David Woodhouse
2006-04-21 9:32 ` Jörn Engel
2006-04-21 9:32 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060420120624.GO25047@stusta.de \
--to=bunk@stusta.de \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.