[KJ] post 2.6.17-rc3 "Stop adding device ids to

[KJ] post 2.6.17-rc3 "Stop adding device ids to

[Henne]

Hi there!

I've seen a change in the Documentation/pci.txt

http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h›860b8c4bde5949b272968597d1426d53080532

Does that really mean, that no Device-ID's should be added or should they be removed from include/linux/pci_ids.h?
They could be replaced in the drivers, if they are used e.g. max 2 times, with the constant values or if they are used
more than 2 times (for drivers who support more devices and check that) moved only to them.

I would write patches if this is in the sense of that.

Greets,
Henne

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] post 2.6.17-rc3 "Stop adding device ids to

[Greg KH]

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

On Fri, Apr 28, 2006 at 09:08:59AM +0200, Henne wrote:
> Hi there!
> 
> I've seen a change in the Documentation/pci.txt
> 
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=9b860b8c4bde5949b272968597d1426d53080532
> 
> Does that really mean, that no Device-ID's should be added or should they 
> be removed from include/linux/pci_ids.h?

No, just what it says, no new device ids should be added to that file,
unless more than one driver uses it.

> They could be replaced in the drivers, if they are used e.g. max 2 times, 
> with the constant values or if they are used
> more than 2 times (for drivers who support more devices and check that) 
> moved only to them.
> 
> I would write patches if this is in the sense of that.

No, this isn't something that needs to be cleaned up, but rather
something that shouldn't happen in the future.

hope this helps,

greg k-h

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors