From: Ingo Molnar <mingo@elte.hu>
To: Patrick McHardy <kaber@trash.net>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
coreteam@netfilter.org, "David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [netfilter-core] Re: [lockup] 2.6.17-rc3: netfilter/sctp: lockup in sctp_new(), do_basic_checks()
Date: Tue, 2 May 2006 16:38:14 +0200 [thread overview]
Message-ID: <20060502143814.GA3789@elte.hu> (raw)
In-Reply-To: <44576CD5.60603@trash.net>
* Patrick McHardy <kaber@trash.net> wrote:
> > + /*
> > + * Dont trust the initial offset:
> > + */
> > + offset = skb->nh.iph->ihl * 4 + sizeof(sctp_sctphdr_t);
> > + if (offset >= skb->len)
> > + return 1;
> > +
>
> That part is unnecessary, the presence of one sctp_sctphdr_t
> has already been verified by skb_header_pointer() in sctp_new().
ok.
> How about this patch (based on your patch, but typos fixed and also
> covers nf_conntrack)?
sure, fine with me!
Ingo
next prev parent reply other threads:[~2006-05-02 14:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-02 11:34 [lockup] 2.6.17-rc3: netfilter/sctp: lockup in sctp_new(), do_basic_checks() Ingo Molnar
2006-05-02 13:40 ` Ingo Molnar
2006-05-02 13:45 ` Ingo Molnar
2006-05-02 13:54 ` [netfilter-core] " Patrick McHardy
2006-05-02 14:01 ` Ingo Molnar
2006-05-02 13:57 ` Patrick McHardy
2006-05-02 14:16 ` Ingo Molnar
2006-05-02 14:24 ` Ingo Molnar
2006-05-02 14:29 ` Patrick McHardy
2006-05-02 14:38 ` Ingo Molnar [this message]
2006-05-02 14:35 ` Patrick McHardy
2006-05-02 14:42 ` Ingo Molnar
2006-05-02 14:40 ` Patrick McHardy
2006-05-02 13:45 ` [netfilter-core] " Patrick McHardy
2006-05-02 15:34 ` Marcel Holtmann
2006-05-02 15:55 ` [netfilter-core] " Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060502143814.GA3789@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.