From: Ralf Baechle <ralf@linux-mips.org>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: linux-mips@linux-mips.org
Subject: Re: SETNAME (set nodename) in syscall.c
Date: Tue, 2 May 2006 17:09:58 +0100 [thread overview]
Message-ID: <20060502160958.GB15052@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0604292059210.24032@shark.he.net>
On Sat, Apr 29, 2006 at 09:01:59PM -0700, Randy.Dunlap wrote:
> In arch/mips/syscall.c::_sys_sysmips(), case SETNAME,
> isn't one of the strncpy() and strlcpy() unneeded?
>
> down_write(&uts_sem);
> strncpy(system_utsname.nodename, nodename, len);
> nodename[__NEW_UTS_LEN] = '\0';
> strlcpy(system_utsname.nodename, nodename,
> sizeof(system_utsname.nodename));
> up_write(&uts_sem);
Seems that came with the 2.5.70 merge and got copied and moved around a
few times since. I'm pretty sure the whole sysmips(SETNAME, ...)
operation is unused.
Any objections again removal of sysmips(SETNAME, ...) support?
Ralf
prev parent reply other threads:[~2006-05-02 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-30 4:01 SETNAME (set nodename) in syscall.c Randy.Dunlap
2006-05-02 16:09 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060502160958.GB15052@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.