* SETNAME (set nodename) in syscall.c
@ 2006-04-30 4:01 Randy.Dunlap
2006-05-02 16:09 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Randy.Dunlap @ 2006-04-30 4:01 UTC (permalink / raw)
To: ralf; +Cc: linux-mips
Hi,
In arch/mips/syscall.c::_sys_sysmips(), case SETNAME,
isn't one of the strncpy() and strlcpy() unneeded?
down_write(&uts_sem);
strncpy(system_utsname.nodename, nodename, len);
nodename[__NEW_UTS_LEN] = '\0';
strlcpy(system_utsname.nodename, nodename,
sizeof(system_utsname.nodename));
up_write(&uts_sem);
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: SETNAME (set nodename) in syscall.c
2006-04-30 4:01 SETNAME (set nodename) in syscall.c Randy.Dunlap
@ 2006-05-02 16:09 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2006-05-02 16:09 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: linux-mips
On Sat, Apr 29, 2006 at 09:01:59PM -0700, Randy.Dunlap wrote:
> In arch/mips/syscall.c::_sys_sysmips(), case SETNAME,
> isn't one of the strncpy() and strlcpy() unneeded?
>
> down_write(&uts_sem);
> strncpy(system_utsname.nodename, nodename, len);
> nodename[__NEW_UTS_LEN] = '\0';
> strlcpy(system_utsname.nodename, nodename,
> sizeof(system_utsname.nodename));
> up_write(&uts_sem);
Seems that came with the 2.5.70 merge and got copied and moved around a
few times since. I'm pretty sure the whole sysmips(SETNAME, ...)
operation is unused.
Any objections again removal of sysmips(SETNAME, ...) support?
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-05-02 16:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-30 4:01 SETNAME (set nodename) in syscall.c Randy.Dunlap
2006-05-02 16:09 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.