Re: [patch 2/6] New Generic HW RNG

[Michael Buesch <mb@bu3sch.de>]

On Sunday 07 May 2006 15:45, you wrote:
> On Sun, May 07, 2006 at 03:27:33PM +0200, Michael Buesch wrote:
> > On Sunday 07 May 2006 15:16, you wrote:
> > > On Sunday 07 May 2006 15:03, you wrote:
> > > > This does not handle the case of partial read correctly - the code
> > > > should be
> > > > 
> > > > 			return ret ? : -ERESTARTSYS;
> > 
> > Or, hm. Shouldn't we
> > return ret ? : err;
> > 
> > err is -EINTR
> 
> -ERESTARTSYS is the proper return code for this case - the signal
> handling code will either convert it to EINTR for userspace, or
> restart the system call after handling the signal, depending on the
> state of the SA_RESTART flag set by sigaction().

Ok, I fixed all your stuff. Thanks.
I will run some more tests now and re-submit, if noone else finds a bug. ;)

-- 
Greetings Michael.