Re: [patch 2/6] New Generic HW RNG

[Greg KH <gregkh@suse.de>]

On Sun, May 07, 2006 at 03:16:08PM +0200, Michael Buesch wrote:
> On Sunday 07 May 2006 15:03, you wrote:
> > > +	list_for_each_entry(rng, &rng_list, list) {
> > > +		if (strncmp(rng->name, buf, len) == 0) {
> > 
> > This will match if the passed string is just a prefix of rng->name.
> > Apparently sysfs guarantees that the buffer passed to ->store will be
> > NUL-terminated, so this should be just a strcmp().
> 
> I am not sure if it is guaranteed NUL terminated. Greg?
> But I will look into this.

Yes it will be.

thanks,

greg k-h