Re: [Qemu-devel] -cc checking wrong

["Jim C. Brown" <jma5@umd.edu>]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

On Mon, May 08, 2006 at 01:53:03AM +0100, Paul Brook wrote:
> You really should test your patches. The patch you attached generates an error 
> if the compiler works.
> 
> Paul
> 

Whoops, sorry about that. I only tested the --cc="ccache gcc" case.

Here's the correct patch.

-- 
Infinite complexity begets infinite beauty.
Infinite precision begets infinite perfection.

[-- Attachment #2: configure.patch --]
[-- Type: text/plain, Size: 452 bytes --]

--- configure.orig	Sun May  7 20:14:23 2006
+++ configure	Sun May  7 20:16:58 2006
@@ -293,8 +293,14 @@
 ar="${cross_prefix}${ar}"
 strip="${cross_prefix}${strip}"
 
-if [ ! -x "`which $cc`" ] ; then
-    echo "Compiler $cc could not be found"
+# check that gcc is able to compile
+cat > $TMPC <<EOF
+int main(void) {
+}
+EOF
+
+if ! $cc -o $TMPE $TMPC 2>/dev/null ; then
+    echo "Compiler $cc either does not exist or does not work"
     exit
 fi