From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] -cc checking wrong
Date: Mon, 8 May 2006 01:53:03 +0100 [thread overview]
Message-ID: <200605080153.03721.paul@codesourcery.com> (raw)
In-Reply-To: <20060508001855.GA15033@jbrown.mylinuxbox.org>
On Monday 08 May 2006 01:18, Jim C. Brown wrote:
> On Mon, May 08, 2006 at 12:46:24AM +0200, Pavel Jan?k wrote:
> > configure contains:
> >
> > if [ ! -x "`which $cc`" ] ; then
> > echo "Compiler $cc could not be found"
> > exit
> > fi
> >
> > You should check if the command compiles, not if it exists and is
> > executable.
>
> Patch attached. Simply tries to compile a dummy program.
You really should test your patches. The patch you attached generates an error
if the compiler works.
Paul
next prev parent reply other threads:[~2006-05-08 0:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-01 7:41 [Qemu-devel] -cc checking wrong Pavel Janík
2006-05-07 22:46 ` Pavel Janík
2006-05-08 0:18 ` Jim C. Brown
2006-05-08 0:34 ` Jim C. Brown
2006-05-08 7:52 ` Pavel Janík
2006-05-08 15:12 ` Jim C. Brown
2006-05-08 18:53 ` Pavel Janík
2006-05-08 19:08 ` Jim C. Brown
2006-05-08 0:53 ` Paul Brook [this message]
2006-05-08 1:13 ` Jim C. Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605080153.03721.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.