Re: [KJ] [PATCH] linux-2.6.17-rc3-git13

Re: [KJ] [PATCH] linux-2.6.17-rc3-git13

[walter harms]

Anne Thrax wrote:
> do_task_stat() was using too much stack
> from make checkstack:
> 0x080eae08 do_task_stat:                                1752
> 
> So I took almost all the variables used in the function and made a new 
> structure do_task_stat_vars, and dynamically allocated it in the function.
> This is supposed to be a quick hack, and hopefully the authors will 
> really do something about it.
> 
> Signed off by: Anne Thrax <foobarfoobarfoobar@gmail.com>
> 
> --- linux-2.6.17-rc3-git13/fs/proc/array.c      2006-05-07 
> 23:01:50.000000000 -0400
> +++ linux-uml/fs/proc/array.c   2006-05-08 01:31:12.000000000 -0400
> @@ -316,7 +316,7 @@
> 
>  static int do_task_stat(struct task_struct *task, char * buffer, int 
> whole)
>  {
> -       unsigned long vsize, eip, esp, wchan = ~0UL;
> +       /* unsigned long vsize, eip, esp, wchan = ~0UL;
>         long priority, nice;
>         int tty_pgrp = -1, tty_nr = 0;
>         sigset_t sigign, sigcatch;
> @@ -332,35 +332,49 @@
>         unsigned long rsslim = 0;
>         struct task_struct *t;
>         char tcomm[sizeof(task->comm)];
> +       */
> +       struct do_task_stat_vars *vars;
> +       vars = kmalloc(sizeof(struct do_task_stat_vars), GFP_KERNEL);
> +       vars->vsize = vars->eip = vars->esp = vars->wchan = ~0UL;
> +       vars->tty_pgrp = -1;
> +       vars->tty_nr = 0;
> +       vars->pgid = -1;
> +       vars->sid = -1;
> +       vars->num_threads = 0;
> +       vars->cmin_flt = vars->cmaj_flt = vars->min_flt = vars->maj_flt 

i am missing a check that kmalloc succeded. i agree with nish that
defining vars outside the header is bad style (but possible for C99, 
unfortunaly).

happy hacking,
  wh
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] linux-2.6.17-rc3-git13

[walter harms]

hi,
i read that some parents in the US force there children not to reveal 
the identify online. This is a problem for the kids.
To help i think they should tell there read identify a trustee and
get a bogus name what appears in the logs. forcing them to reveal
will cause only trouble.

my 2 cents,
  walter



Greg KH wrote:
> On Mon, May 08, 2006 at 10:58:45AM -0600, Matthew Wilcox wrote:
>> On Mon, May 08, 2006 at 09:40:10AM -0700, Greg KH wrote:
>>> On Mon, May 08, 2006 at 08:18:08AM -0700, Nishanth Aravamudan wrote:
>>>> On 08.05.2006 [03:27:10 -0400], Anne Thrax wrote:
>>>>> I would rather not use my real name, as I am only 14 years old.
>>>> I'm not sure I entirely understand how the one stems from the other, but
>>>> I think the spirit of the "personal information" part of the DCO
>>>> (Developer's Certificate of Origin, in Documentation/SubmittingPatches)
>>>> is something like full disclosure. Also, I wonder how, if at all, the
>>>> DCO can be enforced when it involves a minor. I'll defer to Greg on this
>>>> one... at least on whatever precedent exists, I don't expect a legal
>>>> decision, Greg :)
>>> Doesn't matter, we still need a real name.  It's not a legal issue but a
>>> "trace the blame" issue.
>> A pseudonym + email address performs acceptably for "trace the blame".
>> So I don't see how your two statements are related.
> 
> It's a matter of trust.  If you want to trust us to take your changes,
> you need to show that you trust us enough to be willing to accept
> recgonition for those changes.  By using a pseudonym, you are not
> showing a whole lot of trust, and by using it, it take a whole lot more
> effort to get that trust.
> 
> That being said, there are a few pseudonyms out there that I do trust,
> just because they have been around for years and show that they are
> trustworthy people.
> 
> thanks,
> 
> greg k-h
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/kernel-janitors
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] linux-2.6.17-rc3-git13

[Greg KH]

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

On Tue, May 09, 2006 at 10:00:50AM +0200, walter harms wrote:
> 
> hi,
> i read that some parents in the US force there children not to reveal 
> the identify online. This is a problem for the kids.
> To help i think they should tell there read identify a trustee and
> get a bogus name what appears in the logs. forcing them to reveal
> will cause only trouble.

We have had people under 18 submit code all the time in the past.  If a
parent doesn't want their child submitting code in their own name to the
Linux kernel, I would really wonder about that parent...

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] linux-2.6.17-rc3-git13

[walter harms]

Greg KH wrote:
> On Tue, May 09, 2006 at 10:00:50AM +0200, walter harms wrote:
>> hi,
>> i read that some parents in the US force there children not to reveal 
>> the identify online. This is a problem for the kids.
>> To help i think they should tell there read identify a trustee and
>> get a bogus name what appears in the logs. forcing them to reveal
>> will cause only trouble.
> 
> We have had people under 18 submit code all the time in the past.  If a
> parent doesn't want their child submitting code in their own name to the
> Linux kernel, I would really wonder about that parent...
> 
> 
> 

they are scared. look at the press the internet is a pile of porno, 
terrorist, bomb builders and greedy layers that strip you of your money 
if you convert a song in an other file format.

We realy should offer this on request, i guess it will not be used much 
but i thing is a working solution.

re,
  walter
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] linux-2.6.17-rc3-git13

[Anne Thrax]

I think that the issue with the DCO is important, but I'm sort of giving up on reducing
the stack usage for that particular function. I haven't reduced the stack usage all that much, and it only seems to be *HUGE* when I'm using UML (probably should have mentioned that earlier). Also, my solution was horribly ugly. Maybe a DCO discussion should be started in another thread, possibly in LKML?
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors