From: Andreas Herrmann <aherrman@de.ibm.com>
To: James Bottomley <jejb@steeleye.com>,
James Smart <james.smart@emulex.com>
Cc: Linux SCSI <linux-scsi@vger.kernel.org>
Subject: [PATCH] fc transport: correct default value for fc_dev_loss_tmo
Date: Thu, 11 May 2006 11:23:11 +0200 [thread overview]
Message-ID: <20060511092311.GA8077@lion28.ibm.com> (raw)
In current kernels initialization of fc_dev_loss_tmo is wrong.
See fc_remote_port_delete():
int timeout = rport->dev_loss_tmo;
...
fc_queue_devloss_work(shost, &rport->dev_loss_work, timeout * HZ);
So actually a timeout of ((HZ*60)*HZ) is used or with James S's recent
patch we have a timeout of ((HZ*120)*HZ). I think this was not
intentional, so I suggest the following patch to correct this.
Regards,
Andreas
fc transport: correct default value for fc_dev_loss_tmo
Signed-off-by: Andreas Herrmann <aherrman@de.ibm.com>
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index 95c5478..a1cb05e 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -368,7 +368,7 @@ static DECLARE_TRANSPORT_CLASS(fc_rport_
* should insulate the loss of a remote port.
* The maximum will be capped by the value of SCSI_DEVICE_BLOCK_MAX_TIMEOUT.
*/
-static unsigned int fc_dev_loss_tmo = SCSI_DEVICE_BLOCK_MAX_TIMEOUT;
+static unsigned int fc_dev_loss_tmo = SCSI_DEVICE_BLOCK_MAX_TIMEOUT / HZ;
module_param_named(dev_loss_tmo, fc_dev_loss_tmo, int, S_IRUGO|S_IWUSR);
MODULE_PARM_DESC(dev_loss_tmo,
next reply other threads:[~2006-05-11 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-11 9:23 Andreas Herrmann [this message]
2006-05-11 14:37 ` [PATCH] fc transport: correct default value for fc_dev_loss_tmo James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060511092311.GA8077@lion28.ibm.com \
--to=aherrman@de.ibm.com \
--cc=james.smart@emulex.com \
--cc=jejb@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.