All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: linux-scsi@vger.kernel.org
Subject: [RFC] libata support for async scanning
Date: Fri, 12 May 2006 23:05:29 -0600	[thread overview]
Message-ID: <20060513050529.GS12272@parisc-linux.org> (raw)


I don't think SATA target scanning occupies a huge amount of boot time,
however it will currently force all async scanners to complete before it
scans.  The Rolls-Royce solution would be somethinkg akin to the new
scsi_scan_host(), but I don't think that's necessaary.  This patch just
acknowledges that async scanning exists and will permit the drive
additions to finish some time after libata has triggered the probe.

Signed-off-by: Matthew Wilcox <matthew@wil.cx>

Index: ./drivers/scsi/libata-scsi.c
===================================================================
RCS file: /var/cvs/linux-2.6/drivers/scsi/libata-scsi.c,v
retrieving revision 1.38
diff -u -p -r1.38 libata-scsi.c
--- ./drivers/scsi/libata-scsi.c	19 Apr 2006 04:55:59 -0000	1.38
+++ ./drivers/scsi/libata-scsi.c	13 May 2006 04:56:30 -0000
@@ -2733,16 +2733,19 @@ void ata_scsi_simulate(struct ata_port *
 void ata_scsi_scan_host(struct ata_port *ap)
 {
 	struct ata_device *dev;
+	struct async_scan_data *data;
 	unsigned int i;
 
 	if (ap->flags & ATA_FLAG_PORT_DISABLED)
 		return;
 
+	data = scsi_prep_async_scan(ap->host);
 	for (i = 0; i < ATA_MAX_DEVICES; i++) {
 		dev = &ap->device[i];
 
 		if (ata_dev_present(dev))
 			scsi_scan_target(&ap->host->shost_gendev, 0, i, 0, 0);
 	}
+	scsi_finish_async_scan(data);
 }
 

             reply	other threads:[~2006-05-13  5:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-13  5:05 Matthew Wilcox [this message]
2006-05-13  5:16 ` [RFC] libata support for async scanning Jeff Garzik
2006-05-13 13:16   ` Matthew Wilcox
2006-05-14  1:26     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060513050529.GS12272@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.