All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [RFC] libata support for async scanning
Date: Sat, 13 May 2006 01:16:46 -0400	[thread overview]
Message-ID: <44656BBE.7020806@garzik.org> (raw)
In-Reply-To: <20060513050529.GS12272@parisc-linux.org>

Matthew Wilcox wrote:
> I don't think SATA target scanning occupies a huge amount of boot time,
> however it will currently force all async scanners to complete before it
> scans.  The Rolls-Royce solution would be somethinkg akin to the new
> scsi_scan_host(), but I don't think that's necessaary.  This patch just
> acknowledges that async scanning exists and will permit the drive
> additions to finish some time after libata has triggered the probe.

This seems to add needless complexity.

The internal probe is complete before the loop begins.  Thus, 
ata_scan_scan_host() is simply walking data structures in memory (due to 
SCSI simulator) for ATA devices, and for ATAPI devices parallelism is 
largely inadvisable :)  Its overkill, and in some rare cases could make 
debugging more annoying.

	Jeff




  reply	other threads:[~2006-05-13  5:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-13  5:05 [RFC] libata support for async scanning Matthew Wilcox
2006-05-13  5:16 ` Jeff Garzik [this message]
2006-05-13 13:16   ` Matthew Wilcox
2006-05-14  1:26     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44656BBE.7020806@garzik.org \
    --to=jeff@garzik.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.