From: Andrew Morton <akpm@osdl.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: jsipek@fsl.cs.sunysb.edu, linux-kernel@vger.kernel.org
Subject: Re: swapper_space export
Date: Wed, 17 May 2006 08:22:52 -0700 [thread overview]
Message-ID: <20060517082252.47c75004.akpm@osdl.org> (raw)
In-Reply-To: <1147864721.3051.17.camel@laptopd505.fenrus.org>
Arjan van de Ven <arjan@infradead.org> wrote:
>
> On Tue, 2006-05-16 at 19:24 -0400, Josef Sipek wrote:
> > I was trying to compile the Unionfs[1] to get it up to sync it up with
> > the kernel developments from the past few months. Anyway, long story
> > short...swapper_space (defined in mm/swap_state.c) is not exported
> > anymore (git commit: 4936967374c1ad0eb3b734f24875e2484c3786cc). This
> > apparently is not an issue for most modules. Troubles arise when the
> > modules include mm.h or any of its relatives.
> >
> > One simply gets a linker error about swapper_space not being defined.
> > The problem is that it is used in mm.h.
>
>
> don't you think it's really suspect that no other filesystem, in fact no
> other driver in the kernel needs this? Could it just be that unionfs is
> using a wrong API ? Because if that's the case you're patch is just the
> wrong thing. Maybe the unionfs people should try to submit their code
> for review etc......
They're probably just using page_mapping(), which is a reasonable thing to so.
Probably it's sufficient to use page->mapping. It depends how they got
hold of the page. If it's know to be in filesystem pagecache then
page->mapping will be OK.
next prev parent reply other threads:[~2006-05-17 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 23:24 swapper_space export Josef Sipek
2006-05-17 10:15 ` Adrian Bunk
2006-05-17 11:18 ` Arjan van de Ven
2006-05-17 15:22 ` Andrew Morton [this message]
2006-05-17 15:52 ` Hugh Dickins
2006-05-17 19:12 ` Josef Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060517082252.47c75004.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.