All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: swapper_space export
Date: Wed, 17 May 2006 12:15:44 +0200	[thread overview]
Message-ID: <20060517101544.GW10077@stusta.de> (raw)
In-Reply-To: <20060516232443.GA10762@filer.fsl.cs.sunysb.edu>

On Tue, May 16, 2006 at 07:24:43PM -0400, Josef Sipek wrote:
> I was trying to compile the Unionfs[1] to get it up to sync it up with
> the kernel developments from the past few months. Anyway, long story
> short...swapper_space (defined in mm/swap_state.c) is not exported
> anymore (git commit: 4936967374c1ad0eb3b734f24875e2484c3786cc). This
> apparently is not an issue for most modules. Troubles arise when the
> modules include mm.h or any of its relatives.
> 
> One simply gets a linker error about swapper_space not being defined.
> The problem is that it is used in mm.h.
> 
> I included a reverse patch to export the symbol again.

Can we discuss this patch when Unionfs gets submitted for inclusion into 
the kernel?

It's in fact a good thing if you and other people regularly notice that 
external modules do not longer work here or there since it creates 
pressure towards getting external modules submitted for inclusion into 
the kernel.

> Josef "Jeff" Sipek.
>...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2006-05-17 10:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-16 23:24 swapper_space export Josef Sipek
2006-05-17 10:15 ` Adrian Bunk [this message]
2006-05-17 11:18 ` Arjan van de Ven
2006-05-17 15:22   ` Andrew Morton
2006-05-17 15:52   ` Hugh Dickins
2006-05-17 19:12     ` Josef Sipek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060517101544.GW10077@stusta.de \
    --to=bunk@stusta.de \
    --cc=jsipek@fsl.cs.sunysb.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.