From: Jens Axboe <axboe@suse.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: "zhao, forrest" <forrest.zhao@intel.com>,
Tejun Heo <htejun@gmail.com>,
linux-ide@vger.kernel.org
Subject: Re: ata_piix resume from S3 on T43P failed
Date: Wed, 17 May 2006 15:02:33 +0200 [thread overview]
Message-ID: <20060517130233.GN4197@suse.de> (raw)
In-Reply-To: <446B1D76.6010303@garzik.org>
On Wed, May 17 2006, Jeff Garzik wrote:
> Jens Axboe wrote:
> >I think Hugh traced it down to a unrelated timer change. The above
> >really wants to wait for BUSY clear, perhaps the best solution would be
> >to have piix device its own ata_piix_device_resume() that first waits
> >for BUSY clear, then calls ata_device_resume().
>
> Close... all devices should wait for libata to signal that the bus is
> ready to be talked to. For some that's waiting for BSY to clear, for
> others that's checking the SATA bus.
Ok, I meant for the ata_piix case. Same should apply to others, right?
Do whatever you need to do to make sure the hardware is ready, then call
the generic ata_device_resume() helper to handle the libata side of
things.
--
Jens Axboe
next prev parent reply other threads:[~2006-05-17 13:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-11 8:05 ata_piix resume from S3 on T43P failed zhao, forrest
2006-05-11 8:31 ` Tejun Heo
2006-05-11 8:35 ` Tejun Heo
2006-05-11 9:46 ` zhao, forrest
2006-05-11 10:39 ` Tejun Heo
2006-05-12 5:02 ` zhao, forrest
2006-05-11 10:55 ` Jens Axboe
2006-05-12 5:51 ` zhao, forrest
2006-05-12 10:17 ` Jens Axboe
2006-05-12 10:56 ` Tejun Heo
2006-05-16 3:56 ` zhao, forrest
2006-05-17 11:03 ` Jens Axboe
2006-05-17 12:56 ` Jeff Garzik
2006-05-17 13:02 ` Jens Axboe [this message]
2006-05-22 7:32 ` Jeff Garzik
2006-05-13 4:19 ` Jeff Garzik
2006-05-16 1:58 ` zhao, forrest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060517130233.GN4197@suse.de \
--to=axboe@suse.de \
--cc=forrest.zhao@intel.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.