Re: ata_piix resume from S3 on T43P failed

[Tejun Heo <htejun@gmail.com>]

Hello, Zhao, Jens.

Jens Axboe wrote:
> On Fri, May 12 2006, zhao, forrest wrote:
>> On Thu, 2006-05-11 at 12:55 +0200, Jens Axboe wrote:
>>> run dmesg prior to suspending, then it'll be cached and can be run after
>>> resume even if the disk doesn't want to talk to you.
>>>
>> Don't know why the mails with attached files were not sent to mailing
>> list, so I put them at
>> http://www.infradead.org/~forrest/suspend-resume-dmesg/
> 
> The key is the 0xef timeout, then the device is offlined and you see a
> lot of io errors due to that.
> 
> Try this:
> 
> diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
> index bd14720..f120839 100644
> --- a/drivers/scsi/libata-core.c
> +++ b/drivers/scsi/libata-core.c
> @@ -4288,6 +4288,7 @@ int ata_device_resume(struct ata_port *a
>  {
>  	if (ap->flags & ATA_FLAG_SUSPENDED) {
>  		ap->flags &= ~ATA_FLAG_SUSPENDED;
> +		mdelay(2000);
>  		ata_set_mode(ap);
>  	}
>  	if (!ata_dev_present(dev))
> 

If Jens' suggestion doesn't work, can you post the same log with the 
working kernel?  In #upstream, that part of code hasn't changed much, so 
I'm curious what makes the other kernel work.

-- 
tejun