From: apgo@patchbomb.org (Arthur Othieno)
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c
Date: Thu, 18 May 2006 08:10:08 +0000 [thread overview]
Message-ID: <20060518081008.GB20402@krypton> (raw)
In-Reply-To: <20060515121824.GM12726@rotomalug.org>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On Mon, May 15, 2006 at 02:19:09PM +0200, Christophe Lucas wrote:
> Description:
> printk should include appropriate KERN_* constant (of course
> only at beginning of lines).
>
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
>
> Index: linux-2.6.16.16/arch/arm/mach-omap1/board-h3.c
> ===================================================================
> --- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-h3.c 2006-05-11 03:56:24.000000000 +0200
> +++ linux-2.6.16.16/arch/arm/mach-omap1/board-h3.c 2006-05-15 12:25:21.000000000 +0200
> @@ -196,7 +196,7 @@
> {
> omap_cfg_reg(W15_1710_GPIO40);
> if (omap_request_gpio(40) < 0) {
> - printk("Error requesting gpio 40 for smc91x irq\n");
> + printk(KERN_WARNING "Error requesting gpio 40 for smc91x irq\n");
Ditto KERN_ERR.
> return;
> }
> }
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-05-18 8:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-15 12:18 [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
2006-05-15 12:19 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c Christophe Lucas
2006-05-15 12:20 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-innovator.c Christophe Lucas
2006-05-15 14:34 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c Christophe Lucas
2006-05-18 8:08 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Arthur Othieno
2006-05-18 8:10 ` Arthur Othieno [this message]
2006-05-18 8:15 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c Arthur Othieno
2006-05-18 8:19 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-innovator.c Arthur Othieno
2006-05-18 8:25 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h3.c Christophe Lucas
2006-05-18 8:30 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-h2.c Christophe Lucas
2006-05-18 8:35 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c Christophe Lucas
2006-05-26 10:35 ` [KJ] [PATCH] printk : arch/arm/mach-omap1/id.c Christophe Lucas
2006-05-26 11:51 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060518081008.GB20402@krypton \
--to=apgo@patchbomb.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.