Re: [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c

From: apgo@patchbomb.org (Arthur Othieno)
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c
Date: Thu, 18 May 2006 08:15:19 +0000	[thread overview]
Message-ID: <20060518081519.GC20402@krypton> (raw)
In-Reply-To: <20060515121824.GM12726@rotomalug.org>

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]

On Mon, May 15, 2006 at 04:34:45PM +0200, Christophe Lucas wrote:
> Description:
> printk should include appropriate KERN_* constant (of course
> only at beginning of lines).
> 
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> 
> 
> Index: linux-2.6.16.16/arch/arm/mach-omap1/board-osk.c
> ===================================================================
> --- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-osk.c	2006-05-11 03:56:24.000000000 +0200
> +++ linux-2.6.16.16/arch/arm/mach-omap1/board-osk.c	2006-05-15 12:27:32.000000000 +0200
> @@ -148,7 +148,7 @@
>  static void __init osk_init_smc91x(void)
>  {
>  	if ((omap_request_gpio(0)) < 0) {
> -		printk("Error requesting gpio 0 for smc91x irq\n");
> +		printk(KERN_WARNING "Error requesting gpio 0 for smc91x irq\n");

KERN_ERR

>  		return;
>  	}
>  
> @@ -160,7 +160,7 @@
>  {
>  	omap_cfg_reg(M7_1610_GPIO62);
>  	if ((omap_request_gpio(62)) < 0) {
> -		printk("Error requesting gpio 62 for CF irq\n");
> +		printk(KERN_WARNING "Error requesting gpio 62 for CF irq\n");

Ditto.

>  		return;
>  	}
>  	/* the CF I/O IRQ is really active-low */

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors