From: Con Kolivas <kernel@kolivas.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] swap-prefetch, fix lru_cache_add_tail()
Date: Thu, 18 May 2006 16:39:53 +1000 [thread overview]
Message-ID: <200605181639.53546.kernel@kolivas.org> (raw)
In-Reply-To: <1147884867.22400.9.camel@lappy>
On Thursday 18 May 2006 02:54, Peter Zijlstra wrote:
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
>
> lru_cache_add_tail() uses the inactive per-cpu pagevec. This causes
> normal inactive and intactive tail inserts to end up on the wrong end
> of the list.
>
> When the pagevec is completed by lru_cache_add_tail() but still contains
> normal inactive pages, all pages will be added to the inactive tail and
> vice versa.
>
> Also *add_drain*() will always complete to the inactive head.
>
> Add a third per-cpu pagevec to alleviate this problem.
Thanks!
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Con Kolivas <kernel@kolivas.org>
--
-ck
WARNING: multiple messages have this Message-ID (diff)
From: Con Kolivas <kernel@kolivas.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] swap-prefetch, fix lru_cache_add_tail()
Date: Thu, 18 May 2006 16:39:53 +1000 [thread overview]
Message-ID: <200605181639.53546.kernel@kolivas.org> (raw)
In-Reply-To: <1147884867.22400.9.camel@lappy>
On Thursday 18 May 2006 02:54, Peter Zijlstra wrote:
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
>
> lru_cache_add_tail() uses the inactive per-cpu pagevec. This causes
> normal inactive and intactive tail inserts to end up on the wrong end
> of the list.
>
> When the pagevec is completed by lru_cache_add_tail() but still contains
> normal inactive pages, all pages will be added to the inactive tail and
> vice versa.
>
> Also *add_drain*() will always complete to the inactive head.
>
> Add a third per-cpu pagevec to alleviate this problem.
Thanks!
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Con Kolivas <kernel@kolivas.org>
--
-ck
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-05-18 6:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-17 16:54 [PATCH] swap-prefetch, fix lru_cache_add_tail() Peter Zijlstra
2006-05-17 16:54 ` Peter Zijlstra
2006-05-18 6:39 ` Con Kolivas [this message]
2006-05-18 6:39 ` Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605181639.53546.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.