All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mel@csn.ul.ie>
To: akpm@osdl.org
Cc: Mel Gorman <mel@csn.ul.ie>,
	nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org,
	haveblue@us.ibm.com, ak@suse.de, bob.picco@hp.com,
	mbligh@mbligh.org, linux-mm@kvack.org, apw@shadowen.org,
	mingo@elte.hu
Subject: [PATCH 0/2] Fixes for node alignment and flatmem assumptions
Date: Fri, 19 May 2006 14:42:41 +0100 (IST)	[thread overview]
Message-ID: <20060519134241.29021.84756.sendpatchset@skynet> (raw)

After almost 3 days of banging the head on the keyboard, it was discovered
why arch-independent zone-sizing failed on IA64 for the configuration
posted on http://www.zip.com.au/~akpm/linux/patches/stuff/config-ia64 .

The two patches in this set address the following;

1. The buddy allocator requires that the node_mem_map be aligned on
   a MAX_ORDER boundary. Patch 1 from Bob Picco's patch aligns the
   node_map_map correctly.

2. This is the one that was giving me keyboard face. The FLATMEM memory
   model assumes that

   mem_map[0] == NODE_DATA(0)->node_mem_map == PFN 0

   This is not the case on IA64 with arch-independent zone sizing because
   NODE_DATA(0)->node_mem_map starts where the first valid page frame is. On
   my test machine, that is PFN 1025 but it probably varies.  Patch 2 from Andy
   Whitcroft relaxes the assumption that NODE_DATA(0)->node_mem_map == PFN 0 .

These patches apply to 2.6.17-rc4-mm1 and are independent of
architecture-independent zone sizing. Patch 1 in particular fixes a
real problem that is just difficult to trigger. However, once applied,
have-ia64-use-add_active_range-and-free_area_init_nodes.patch will work again.

2.6.17-rc4-mm1 with this patchset have been boot-tested by me
and verified that /proc/zoneinfo is ok on x86, ppc64, x86_64 and
ia64 in a variety of configurations. Bob Picco also says that both
patches passed a test with mem=750M and 4Gb on a rx2600 (ia64) with
large memory holes. They have also been successfully tested with
have-ia64-use-add_active_range-and-free_area_init_nodes.patch added back in.
-- 
-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mel@csn.ul.ie>
To: akpm@osdl.org
Cc: Mel Gorman <mel@csn.ul.ie>,
	nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org,
	haveblue@us.ibm.com, ak@suse.de, bob.picco@hp.com,
	mbligh@mbligh.org, linux-mm@kvack.org, apw@shadowen.org,
	mingo@elte.hu
Subject: [PATCH 0/2] Fixes for node alignment and flatmem assumptions
Date: Fri, 19 May 2006 14:42:41 +0100 (IST)	[thread overview]
Message-ID: <20060519134241.29021.84756.sendpatchset@skynet> (raw)

After almost 3 days of banging the head on the keyboard, it was discovered
why arch-independent zone-sizing failed on IA64 for the configuration
posted on http://www.zip.com.au/~akpm/linux/patches/stuff/config-ia64 .

The two patches in this set address the following;

1. The buddy allocator requires that the node_mem_map be aligned on
   a MAX_ORDER boundary. Patch 1 from Bob Picco's patch aligns the
   node_map_map correctly.

2. This is the one that was giving me keyboard face. The FLATMEM memory
   model assumes that

   mem_map[0] == NODE_DATA(0)->node_mem_map == PFN 0

   This is not the case on IA64 with arch-independent zone sizing because
   NODE_DATA(0)->node_mem_map starts where the first valid page frame is. On
   my test machine, that is PFN 1025 but it probably varies.  Patch 2 from Andy
   Whitcroft relaxes the assumption that NODE_DATA(0)->node_mem_map == PFN 0 .

These patches apply to 2.6.17-rc4-mm1 and are independent of
architecture-independent zone sizing. Patch 1 in particular fixes a
real problem that is just difficult to trigger. However, once applied,
have-ia64-use-add_active_range-and-free_area_init_nodes.patch will work again.

2.6.17-rc4-mm1 with this patchset have been boot-tested by me
and verified that /proc/zoneinfo is ok on x86, ppc64, x86_64 and
ia64 in a variety of configurations. Bob Picco also says that both
patches passed a test with mem=750M and 4Gb on a rx2600 (ia64) with
large memory holes. They have also been successfully tested with
have-ia64-use-add_active_range-and-free_area_init_nodes.patch added back in.
-- 
-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2006-05-19 13:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-19 13:42 Mel Gorman [this message]
2006-05-19 13:42 ` [PATCH 0/2] Fixes for node alignment and flatmem assumptions Mel Gorman
2006-05-19 13:43 ` [PATCH 1/2] Align the node_mem_map endpoints to a MAX_ORDER boundary Mel Gorman
2006-05-19 13:43   ` Mel Gorman
2006-05-19 20:49   ` Andrew Morton
2006-05-19 20:49     ` Andrew Morton
2006-05-19 23:25     ` Mel Gorman
2006-05-19 23:25       ` Mel Gorman
2006-05-22  8:25     ` Andy Whitcroft
2006-05-22  8:25       ` Andy Whitcroft
2006-05-22  8:44       ` Andrew Morton
2006-05-22  8:44         ` Andrew Morton
2006-05-19 13:43 ` [PATCH 2/2] FLATMEM relax requirement for memory to start at pfn 0 Mel Gorman
2006-05-19 13:43   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060519134241.29021.84756.sendpatchset@skynet \
    --to=mel@csn.ul.ie \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=apw@shadowen.org \
    --cc=bob.picco@hp.com \
    --cc=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mbligh@mbligh.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.