All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Dave Peterson <dsp@llnl.gov>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
	nickpiggin@yahoo.com.au, ak@suse.de, linux-mm@kvack.org,
	garlick@llnl.gov, mgrondona@llnl.gov, dsp@llnl.gov
Subject: Re: [PATCH (try #2)] mm: avoid unnecessary OOM kills
Date: Mon, 22 May 2006 15:12:27 -0700	[thread overview]
Message-ID: <20060522151227.37fd9e51.pj@sgi.com> (raw)
In-Reply-To: <200605222143.k4MLhs2w021071@calaveras.llnl.gov>

Dave wrote:
> -	if (printk_ratelimit()) {
> -		printk("oom-killer: gfp_mask=0x%x, order=%d\n",
> -			gfp_mask, order);
> -		dump_stack();
> -		show_mem();
> -	}
> -
> +	printk("oom-killer: gfp_mask=0x%x, order=%d\n", gfp_mask, order);
> +	dump_stack();
> +	show_mem();

Why disable this printk_ratelimit?  Does this expose us to a Denial of
Service attack from someone forcing multiple oom-kills in a small
cpuset, generating much kernel printk output?

> +/* Try to allocate one more time before invoking the OOM killer. */
> +static struct page * oom_alloc(gfp_t gfp_mask, unsigned int order,

This comment is slightly stale.  Not only does oom_alloc() try one
more allocation, it also actually does invoke the OOM killer.

How about the comment:

   /* Serialize oom killing, while trying to allocate a page */

Or some such ..

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

WARNING: multiple messages have this Message-ID (diff)
From: Paul Jackson <pj@sgi.com>
To: Dave Peterson <dsp@llnl.gov>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
	nickpiggin@yahoo.com.au, ak@suse.de, linux-mm@kvack.org,
	garlick@llnl.gov, mgrondona@llnl.gov
Subject: Re: [PATCH (try #2)] mm: avoid unnecessary OOM kills
Date: Mon, 22 May 2006 15:12:27 -0700	[thread overview]
Message-ID: <20060522151227.37fd9e51.pj@sgi.com> (raw)
In-Reply-To: <200605222143.k4MLhs2w021071@calaveras.llnl.gov>

Dave wrote:
> -	if (printk_ratelimit()) {
> -		printk("oom-killer: gfp_mask=0x%x, order=%d\n",
> -			gfp_mask, order);
> -		dump_stack();
> -		show_mem();
> -	}
> -
> +	printk("oom-killer: gfp_mask=0x%x, order=%d\n", gfp_mask, order);
> +	dump_stack();
> +	show_mem();

Why disable this printk_ratelimit?  Does this expose us to a Denial of
Service attack from someone forcing multiple oom-kills in a small
cpuset, generating much kernel printk output?

> +/* Try to allocate one more time before invoking the OOM killer. */
> +static struct page * oom_alloc(gfp_t gfp_mask, unsigned int order,

This comment is slightly stale.  Not only does oom_alloc() try one
more allocation, it also actually does invoke the OOM killer.

How about the comment:

   /* Serialize oom killing, while trying to allocate a page */

Or some such ..

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-05-22 22:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-22 21:43 [PATCH (try #2)] mm: avoid unnecessary OOM kills Dave Peterson
2006-05-22 21:43 ` Dave Peterson
2006-05-22 22:12 ` Paul Jackson [this message]
2006-05-22 22:12   ` Paul Jackson
2006-05-22 23:35   ` Dave Peterson
2006-05-22 23:35     ` Dave Peterson
2006-05-22 23:54     ` Paul Jackson
2006-05-22 23:54       ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060522151227.37fd9e51.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=dsp@llnl.gov \
    --cc=garlick@llnl.gov \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgrondona@llnl.gov \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.