[PATCH] Late console

[PATCH] Late console

[Rodolfo Giometti]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

Hello,

due my job on sleep I need the serial console till sleep time so let
me propose this patch that disables serial port suspend if a console
is running on it and the kernel has CONFIG_DEBUG_KERNEL flag on.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@enneenne.com
Linux Device Driver                             giometti@gnudd.com
Embedded Systems                     		giometti@linux.it
UNIX programming                     phone:     +39 349 2432127

[-- Attachment #2: patch-au1x00-late-console --]
[-- Type: text/plain, Size: 594 bytes --]

diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c
index 9e27aee..27ed4f2 100644
--- a/drivers/serial/serial_core.c
+++ b/drivers/serial/serial_core.c
@@ -1919,6 +1919,14 @@ int uart_suspend_port(struct uart_driver
 {
 	struct uart_state *state = drv->state + port->line;
 
+#ifdef CONFIG_DEBUG_KERNEL
+	if (uart_console(port)) {
+		printk(KERN_INFO "warning! Serial console %s%d is not disabled in debug kernel mode\n",
+			drv->dev_name, port->line);
+		return 0;
+	}
+#endif
+
 	mutex_lock(&state->mutex);
 
 	if (state->info && state->info->flags & UIF_INITIALIZED) {

Re: [PATCH] Late console

[Ralf Baechle]

On Tue, May 23, 2006 at 03:40:12PM +0200, Rodolfo Giometti wrote:

> due my job on sleep I need the serial console till sleep time so let
> me propose this patch that disables serial port suspend if a console
> is running on it and the kernel has CONFIG_DEBUG_KERNEL flag on.

Patches for drivers/serial/ to:

8250/16?50 (AND CLONE UARTS) SERIAL DRIVER
P:      Russell King
M:      rmk+serial@arm.linux.org.uk
L:      linux-serial@vger.kernel.org
W:      http://serial.sourceforge.net
S:      Maintained

  Ralf

Re: [PATCH] Late console

[Rodolfo Giometti]

On Tue, May 23, 2006 at 04:33:11PM +0100, Ralf Baechle wrote:
> 
> Patches for drivers/serial/ to:
> 
> 8250/16?50 (AND CLONE UARTS) SERIAL DRIVER
> P:      Russell King
> M:      rmk+serial@arm.linux.org.uk
> L:      linux-serial@vger.kernel.org
> W:      http://serial.sourceforge.net
> S:      Maintained

Yes, you are right, but before sending the patch there I'd like to
know what do you think about.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@enneenne.com
Linux Device Driver                             giometti@gnudd.com
Embedded Systems                     		giometti@linux.it
UNIX programming                     phone:     +39 349 2432127

Re: [PATCH] Late console

[Ralf Baechle]

On Tue, May 23, 2006 at 05:33:59PM +0200, Rodolfo Giometti wrote:

> > 8250/16?50 (AND CLONE UARTS) SERIAL DRIVER
> > P:      Russell King
> > M:      rmk+serial@arm.linux.org.uk
> > L:      linux-serial@vger.kernel.org
> > W:      http://serial.sourceforge.net
> > S:      Maintained
> 
> Yes, you are right, but before sending the patch there I'd like to
> know what do you think about.

Nothing wrong at a glance.

  Ralf

[PATCH] Late console

[Rodolfo Giometti]

[-- Attachment #1.1: Type: text/plain, Size: 529 bytes --]

Hello,

due my job on sleep mode for MIPS au1x00 I need the serial console
till sleep time so let me propose this patch that disables serial port
suspend if a console is running on it and the kernel has
CONFIG_DEBUG_KERNEL flag on.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@enneenne.com
Linux Device Driver                             giometti@gnudd.com
Embedded Systems                     		giometti@linux.it
UNIX programming                     phone:     +39 349 2432127

[-- Attachment #1.2: patch-au1x00-late-console --]
[-- Type: text/plain, Size: 613 bytes --]

diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c
index 9e27aee..27ed4f2 100644
--- a/drivers/serial/serial_core.c
+++ b/drivers/serial/serial_core.c
@@ -1919,6 +1919,14 @@ int uart_suspend_port(struct uart_driver
 {
 	struct uart_state *state = drv->state + port->line;
 
+#ifdef CONFIG_DEBUG_KERNEL
+	if (uart_console(port)) {
+		printk(KERN_INFO "warning! Serial console %s%d is not disabled in debug kernel mode\n",
+			drv->dev_name, port->line);
+		return 0;
+	}
+#endif
+
 	mutex_lock(&state->mutex);
 
 	if (state->info && state->info->flags & UIF_INITIALIZED) {

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]