RE: [PATCH] megaraid_mbox: fix section mismatch warnings

RE: [PATCH] megaraid_mbox: fix section mismatch warnings

[Ju, Seokmann]

> Why would you want to do that?  A subfunction of a __devinit function
> should also be __devinit (unless it's alsoi used by something which
> isn't __devinit, of course)
For similar reason as you pointed out, I thought it would be good to remove (unless it is required) the tag so that it can be called by any functions in the driver if needed be.
I don't have enough knowledge on the topic, unfortunately. Is it hardly required to have the tag on all sub-functions called in the function?
If so, there are couple of other sub-functions need to have the tag.

Thank you,

Seokmann

> -----Original Message-----
> From: Matthew Wilcox [mailto:matthew@wil.cx] 
> Sent: Tuesday, May 30, 2006 1:03 PM
> To: Ju, Seokmann
> Cc: Randy.Dunlap; __smail D?nmez; scsi; akpm; jejb; Kolli, Neela
> Subject: Re: [PATCH] megaraid_mbox: fix section mismatch warnings
> 
> On Tue, May 30, 2006 at 07:37:18AM -0600, Ju, Seokmann wrote:
> > >   */
> > > -static int __init
> > > +static int __devinit
> > >  megaraid_init_mbox(adapter_t *adapter)
> 
> > Thank you for pointing out a bug.
> > However, in my opinion, I would rather to simply remove 
> '__init' from the function.
> > The function is just a sub function called by 
> megaraid_probe_one which has '__devinit' tag.
> > Please let me know if this is acceptable.
> > I will submit a patch with proper change.
> 
> Why would you want to do that?  A subfunction of a __devinit function
> should also be __devinit (unless it's alsoi used by something which
> isn't __devinit, of course)
> 

Re: [PATCH] megaraid_mbox: fix section mismatch warnings

[Matthew Wilcox]

On Tue, May 30, 2006 at 11:11:59AM -0600, Ju, Seokmann wrote:
> > Why would you want to do that?  A subfunction of a __devinit function
> > should also be __devinit (unless it's alsoi used by something which
> > isn't __devinit, of course)
> For similar reason as you pointed out, I thought it would be good to remove (unless it is required) the tag so that it can be called by any functions in the driver if needed be.

If it turns out you want to call it from elsewhere in the driver, you
should remove the __devinit tag at that time.

> I don't have enough knowledge on the topic, unfortunately. Is it hardly required to have the tag on all sub-functions called in the function?
> If so, there are couple of other sub-functions need to have the tag.

It's not required, but it is a good idea.  Marking the function as
__devinit allows the function to be discarded when we know it can't be
called again (an infrequent case these days, to be sure, but one the
embedded people are grateful for).

RE: [PATCH] megaraid_mbox: fix section mismatch warnings

[Ju, Seokmann]

Hi,

Thursday, May 25, 2006 12:46 PM, Randy Dunlap wrote:
> Fix section warning:
> WARNING: drivers/scsi/megaraid/megaraid_mbox.o - Section 
> mismatch: reference to .init.text: from .text between 
> 'megaraid_probe_one' (at offset 0x171e) and 'megaraid_queue_command'
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
>  drivers/scsi/megaraid/megaraid_mbox.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2617-rc5.orig/drivers/scsi/megaraid/megaraid_mbox.c
> +++ linux-2617-rc5/drivers/scsi/megaraid/megaraid_mbox.c
> @@ -714,7 +714,7 @@ megaraid_io_detach(adapter_t *adapter)
>   * . Allocate memory required for all the commands
>   * . Use internal library of FW routines, build up complete 
> soft state
>   */
> -static int __init
> +static int __devinit
>  megaraid_init_mbox(adapter_t *adapter)
>  {
>  	struct pci_dev		*pdev;
Thank you for pointing out a bug.
However, in my opinion, I would rather to simply remove '__init' from the function.
The function is just a sub function called by megaraid_probe_one which has '__devinit' tag.
Please let me know if this is acceptable.
I will submit a patch with proper change.

Thanks,

Seokmann

> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org 
> [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Randy.Dunlap
> Sent: Thursday, May 25, 2006 12:46 PM
> To: __smail Dönmez; scsi
> Cc: akpm; jejb; Kolli, Neela
> Subject: [PATCH] megaraid_mbox: fix section mismatch warnings
> 
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Fix section warning:
> WARNING: drivers/scsi/megaraid/megaraid_mbox.o - Section 
> mismatch: reference to .init.text: from .text between 
> 'megaraid_probe_one' (at offset 0x171e) and 'megaraid_queue_command'
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
>  drivers/scsi/megaraid/megaraid_mbox.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2617-rc5.orig/drivers/scsi/megaraid/megaraid_mbox.c
> +++ linux-2617-rc5/drivers/scsi/megaraid/megaraid_mbox.c
> @@ -714,7 +714,7 @@ megaraid_io_detach(adapter_t *adapter)
>   * . Allocate memory required for all the commands
>   * . Use internal library of FW routines, build up complete 
> soft state
>   */
> -static int __init
> +static int __devinit
>  megaraid_init_mbox(adapter_t *adapter)
>  {
>  	struct pci_dev		*pdev;
> 
> 
> ---
> -
> To unsubscribe from this list: send the line "unsubscribe 
> linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] megaraid_mbox: fix section mismatch warnings

[Randy.Dunlap]

On Tue, 30 May 2006 07:37:18 -0600 Ju, Seokmann wrote:

> Hi,
> 
> Thursday, May 25, 2006 12:46 PM, Randy Dunlap wrote:
> > Fix section warning:
> > WARNING: drivers/scsi/megaraid/megaraid_mbox.o - Section 
> > mismatch: reference to .init.text: from .text between 
> > 'megaraid_probe_one' (at offset 0x171e) and 'megaraid_queue_command'
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > ---
> >  drivers/scsi/megaraid/megaraid_mbox.c |    2 +-
> >  1 files changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linux-2617-rc5.orig/drivers/scsi/megaraid/megaraid_mbox.c
> > +++ linux-2617-rc5/drivers/scsi/megaraid/megaraid_mbox.c
> > @@ -714,7 +714,7 @@ megaraid_io_detach(adapter_t *adapter)
> >   * . Allocate memory required for all the commands
> >   * . Use internal library of FW routines, build up complete 
> > soft state
> >   */
> > -static int __init
> > +static int __devinit
> >  megaraid_init_mbox(adapter_t *adapter)
> >  {
> >  	struct pci_dev		*pdev;
> Thank you for pointing out a bug.
> However, in my opinion, I would rather to simply remove '__init' from the function.
> The function is just a sub function called by megaraid_probe_one which has '__devinit' tag.
> Please let me know if this is acceptable.
> I will submit a patch with proper change.

Sure, go for it.

> Thanks,
> 
> Seokmann
> 
> > -----Original Message-----
> > From: linux-scsi-owner@vger.kernel.org 
> > [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Randy.Dunlap
> > Sent: Thursday, May 25, 2006 12:46 PM
> > To: __smail Dönmez; scsi
> > Cc: akpm; jejb; Kolli, Neela
> > Subject: [PATCH] megaraid_mbox: fix section mismatch warnings
> > 
> > From: Randy Dunlap <rdunlap@xenotime.net>
> > 
> > Fix section warning:
> > WARNING: drivers/scsi/megaraid/megaraid_mbox.o - Section 
> > mismatch: reference to .init.text: from .text between 
> > 'megaraid_probe_one' (at offset 0x171e) and 'megaraid_queue_command'
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > ---
> >  drivers/scsi/megaraid/megaraid_mbox.c |    2 +-
> >  1 files changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linux-2617-rc5.orig/drivers/scsi/megaraid/megaraid_mbox.c
> > +++ linux-2617-rc5/drivers/scsi/megaraid/megaraid_mbox.c
> > @@ -714,7 +714,7 @@ megaraid_io_detach(adapter_t *adapter)
> >   * . Allocate memory required for all the commands
> >   * . Use internal library of FW routines, build up complete 
> > soft state
> >   */
> > -static int __init
> > +static int __devinit
> >  megaraid_init_mbox(adapter_t *adapter)
> >  {
> >  	struct pci_dev		*pdev;

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] megaraid_mbox: fix section mismatch warnings

[Matthew Wilcox]

On Tue, May 30, 2006 at 07:37:18AM -0600, Ju, Seokmann wrote:
> >   */
> > -static int __init
> > +static int __devinit
> >  megaraid_init_mbox(adapter_t *adapter)

> Thank you for pointing out a bug.
> However, in my opinion, I would rather to simply remove '__init' from the function.
> The function is just a sub function called by megaraid_probe_one which has '__devinit' tag.
> Please let me know if this is acceptable.
> I will submit a patch with proper change.

Why would you want to do that?  A subfunction of a __devinit function
should also be __devinit (unless it's alsoi used by something which
isn't __devinit, of course)

[PATCH] megaraid_mbox: fix section mismatch warnings

[Randy.Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

Fix section warning:
WARNING: drivers/scsi/megaraid/megaraid_mbox.o - Section mismatch: reference to .init.text: from .text between 'megaraid_probe_one' (at offset 0x171e) and 'megaraid_queue_command'

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 drivers/scsi/megaraid/megaraid_mbox.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

--- linux-2617-rc5.orig/drivers/scsi/megaraid/megaraid_mbox.c
+++ linux-2617-rc5/drivers/scsi/megaraid/megaraid_mbox.c
@@ -714,7 +714,7 @@ megaraid_io_detach(adapter_t *adapter)
  * . Allocate memory required for all the commands
  * . Use internal library of FW routines, build up complete soft state
  */
-static int __init
+static int __devinit
 megaraid_init_mbox(adapter_t *adapter)
 {
 	struct pci_dev		*pdev;


---

Re: [PATCH] megaraid_mbox: fix section mismatch warnings

[Andrew Morton]

"Randy.Dunlap" <rdunlap@xenotime.net> wrote:
>
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Fix section warning:
> WARNING: drivers/scsi/megaraid/megaraid_mbox.o - Section mismatch: reference to .init.text: from .text between 'megaraid_probe_one' (at offset 0x171e) and 'megaraid_queue_command'
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
>  drivers/scsi/megaraid/megaraid_mbox.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2617-rc5.orig/drivers/scsi/megaraid/megaraid_mbox.c
> +++ linux-2617-rc5/drivers/scsi/megaraid/megaraid_mbox.c
> @@ -714,7 +714,7 @@ megaraid_io_detach(adapter_t *adapter)
>   * . Allocate memory required for all the commands
>   * . Use internal library of FW routines, build up complete soft state
>   */
> -static int __init
> +static int __devinit
>  megaraid_init_mbox(adapter_t *adapter)
>  {
>  	struct pci_dev		*pdev;
> 
> 

<trying to get the old brain sorted out here>

This one's a bugfix, isn't it?  In the CONFIG_HOTPLUG kernel the __devinit
megaraid_probe_one() resides in .text and calls the __init
megaraid_init_mbox(), which isn't there any more.  So if this driver is
statically linked into vmlinux and the kernel is hotplug-capable and if
someone hotplugs one of these devices we go blam.

You agree with that analysis?

If so, I'll toss this onto the 2.6.17 pile, thanks.

Re: [PATCH] megaraid_mbox: fix section mismatch warnings

[Randy.Dunlap]

On Thu, 25 May 2006 14:39:50 -0700 Andrew Morton wrote:

> "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
> >
> > From: Randy Dunlap <rdunlap@xenotime.net>
> > 
> > Fix section warning:
> > WARNING: drivers/scsi/megaraid/megaraid_mbox.o - Section mismatch: reference to .init.text: from .text between 'megaraid_probe_one' (at offset 0x171e) and 'megaraid_queue_command'
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > ---
> >  drivers/scsi/megaraid/megaraid_mbox.c |    2 +-
> >  1 files changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linux-2617-rc5.orig/drivers/scsi/megaraid/megaraid_mbox.c
> > +++ linux-2617-rc5/drivers/scsi/megaraid/megaraid_mbox.c
> > @@ -714,7 +714,7 @@ megaraid_io_detach(adapter_t *adapter)
> >   * . Allocate memory required for all the commands
> >   * . Use internal library of FW routines, build up complete soft state
> >   */
> > -static int __init
> > +static int __devinit
> >  megaraid_init_mbox(adapter_t *adapter)
> >  {
> >  	struct pci_dev		*pdev;
> > 
> > 
> 
> <trying to get the old brain sorted out here>
> 
> This one's a bugfix, isn't it?  In the CONFIG_HOTPLUG kernel the __devinit
> megaraid_probe_one() resides in .text and calls the __init
> megaraid_init_mbox(), which isn't there any more.  So if this driver is
> statically linked into vmlinux and the kernel is hotplug-capable and if
> someone hotplugs one of these devices we go blam.
> 
> You agree with that analysis?
> 
> If so, I'll toss this onto the 2.6.17 pile, thanks.

Yes, agreed.

Thanks,
---
~Randy