From: Greg KH <gregkh@suse.de>
To: John Keller <jpk@sgi.com>
Cc: linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org,
pcihpd-discuss@lists.sourceforge.net
Subject: Re: [PATCH 1/2] - Altix: Add initial ACPI support
Date: Wed, 31 May 2006 16:34:08 -0700 [thread overview]
Message-ID: <20060531233408.GA21244@suse.de> (raw)
In-Reply-To: <20060531212320.32044.49013.sendpatchset@attica.americas.sgi.com>
On Wed, May 31, 2006 at 04:23:20PM -0500, John Keller wrote:
> Index: acpi-support/arch/ia64/pci/pci.c
> ===================================================================
> --- acpi-support.orig/arch/ia64/pci/pci.c 2006-05-31 12:37:50.539921986 -0500
> +++ acpi-support/arch/ia64/pci/pci.c 2006-05-31 14:10:50.889146925 -0500
> @@ -470,10 +470,11 @@ pcibios_fixup_resources(struct pci_dev *
> }
> }
>
> -static void __devinit pcibios_fixup_device_resources(struct pci_dev *dev)
> +void __devinit pcibios_fixup_device_resources(struct pci_dev *dev)
> {
> pcibios_fixup_resources(dev, 0, PCI_BRIDGE_RESOURCES);
> }
> +EXPORT_SYMBOL(pcibios_fixup_device_resources);
EXPORT_SYMBOL_GPL() perhaps?
> --- acpi-support.orig/include/linux/pci.h 2006-05-31 12:37:50.647911309 -0500
> +++ acpi-support/include/linux/pci.h 2006-05-31 14:10:50.989137400 -0500
> @@ -397,6 +397,7 @@ extern struct bus_type pci_bus_type;
> extern struct list_head pci_root_buses; /* list of all known PCI buses */
> extern struct list_head pci_devices; /* list of all devices */
>
> +void __devinit pcibios_fixup_device_resources(struct pci_dev *);
Don't put __devinit on a function prototype. It does nothing.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: John Keller <jpk@sgi.com>
Cc: linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org,
pcihpd-discuss@lists.sourceforge.net
Subject: Re: [PATCH 1/2] - Altix: Add initial ACPI support
Date: Wed, 31 May 2006 23:34:08 +0000 [thread overview]
Message-ID: <20060531233408.GA21244@suse.de> (raw)
In-Reply-To: <20060531212320.32044.49013.sendpatchset@attica.americas.sgi.com>
On Wed, May 31, 2006 at 04:23:20PM -0500, John Keller wrote:
> Index: acpi-support/arch/ia64/pci/pci.c
> =================================> --- acpi-support.orig/arch/ia64/pci/pci.c 2006-05-31 12:37:50.539921986 -0500
> +++ acpi-support/arch/ia64/pci/pci.c 2006-05-31 14:10:50.889146925 -0500
> @@ -470,10 +470,11 @@ pcibios_fixup_resources(struct pci_dev *
> }
> }
>
> -static void __devinit pcibios_fixup_device_resources(struct pci_dev *dev)
> +void __devinit pcibios_fixup_device_resources(struct pci_dev *dev)
> {
> pcibios_fixup_resources(dev, 0, PCI_BRIDGE_RESOURCES);
> }
> +EXPORT_SYMBOL(pcibios_fixup_device_resources);
EXPORT_SYMBOL_GPL() perhaps?
> --- acpi-support.orig/include/linux/pci.h 2006-05-31 12:37:50.647911309 -0500
> +++ acpi-support/include/linux/pci.h 2006-05-31 14:10:50.989137400 -0500
> @@ -397,6 +397,7 @@ extern struct bus_type pci_bus_type;
> extern struct list_head pci_root_buses; /* list of all known PCI buses */
> extern struct list_head pci_devices; /* list of all devices */
>
> +void __devinit pcibios_fixup_device_resources(struct pci_dev *);
Don't put __devinit on a function prototype. It does nothing.
thanks,
greg k-h
next prev parent reply other threads:[~2006-05-31 23:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-31 21:23 [PATCH 1/2] - Altix: Add initial ACPI support John Keller
2006-05-31 21:23 ` John Keller
2006-05-31 23:34 ` Greg KH [this message]
2006-05-31 23:34 ` Greg KH
2006-06-05 20:23 ` John Keller
2006-06-05 20:23 ` John Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060531233408.GA21244@suse.de \
--to=gregkh@suse.de \
--cc=jpk@sgi.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.