All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Recent patches for qemu block-cow.c etc breaks Win32 build becaus e of fsync()
Date: Thu, 8 Jun 2006 22:50:53 +0100	[thread overview]
Message-ID: <200606082250.53790.paul@codesourcery.com> (raw)
In-Reply-To: <Pine.LNX.4.63.0606082336280.28873@wbgn013.biozentrum.uni-wuerzburg.de>

> > > Why not define it in config-host.mak like this:
> > >
> > > --- configure.old	2006-06-08 23:06:48.000000000 +0200
> > > +++ configure	2006-06-08 23:07:10.000000000 +0200
> > > @@ -102,6 +102,7 @@
> > >  ;;
> > >  MINGW32*)
> > >  mingw32="yes"
> > > +CFLAGS="-Dfsync=_commit"
> > >  ;;
> > >  FreeBSD)
> > >  bsd="yes"
> >
> > No. This is what header files are for.
>
> Yes, but MS did not provide fsync in header files ;-)

I mean you should add a #define in a header file somewhere (eg. vl.h where 
there are already similar things), not do it via a commandline option.

Paul

  reply	other threads:[~2006-06-08 21:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-08 21:02 [Qemu-devel] Recent patches for qemu block-cow.c etc breaks Win32 build becaus e of fsync() Armistead, Jason
2006-06-08 21:07 ` Johannes Schindelin
2006-06-08 21:14   ` Christian MICHON
2006-06-08 21:17   ` Paul Brook
2006-06-08 21:37     ` Johannes Schindelin
2006-06-08 21:50       ` Paul Brook [this message]
2006-06-08 22:00         ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606082250.53790.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.