From: Dave Jones <davej@redhat.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Add KERN constants to arch/i386/kernel/cpu/rise.c
Date: Sun, 11 Jun 2006 23:30:34 +0000 [thread overview]
Message-ID: <20060611233034.GD13139@redhat.com> (raw)
In-Reply-To: <448CA38C.1050602@gmail.com>
On Sun, Jun 11, 2006 at 06:13:16PM -0500, Matthew Martin wrote:
> Hello,
> This adds KERN constants to arch/i386/kernel/cpu/rise.c
>
> Signed-Off-By: Matthew Martin <lihnucks@gmail.com>
> ---
>
>
> --- vanilla-linux-2.6.16/arch/i386/kernel/cpu/rise.c 2006-03-19 23:53:29.000000000 -0600
> +++ linux-2.6.16/arch/i386/kernel/cpu/rise.c 2006-06-09 18:45:17.000000000 -0500
> @@ -7,9 +7,9 @@
>
> static void __init init_rise(struct cpuinfo_x86 *c)
> {
> - printk("CPU: Rise iDragon");
> + printk(KERN_INFO "CPU: Rise iDragon");
> if (c->x86_model > 2)
> - printk(" II");
> + printk(KERN_INFO " II");
> printk("\n");
Note that there's no \n on the first printk. This means that adding teh KERN_INFO
to the second printk is incorrect, as it'll result in output like..
CPU: Rise iDragon<6> II
Dave
--
http://www.codemonkey.org.uk
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-06-11 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-11 23:13 [KJ] [PATCH] Add KERN constants to arch/i386/kernel/cpu/rise.c Matthew Martin
2006-06-11 23:30 ` Dave Jones [this message]
2006-06-12 3:01 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060611233034.GD13139@redhat.com \
--to=davej@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.