* [KJ] [PATCH] Add KERN constants to arch/i386/kernel/cpu/rise.c
@ 2006-06-11 23:13 Matthew Martin
2006-06-11 23:30 ` Dave Jones
2006-06-12 3:01 ` Randy.Dunlap
0 siblings, 2 replies; 3+ messages in thread
From: Matthew Martin @ 2006-06-11 23:13 UTC (permalink / raw)
To: kernel-janitors
Hello,
This adds KERN constants to arch/i386/kernel/cpu/rise.c
Signed-Off-By: Matthew Martin <lihnucks@gmail.com>
---
--- vanilla-linux-2.6.16/arch/i386/kernel/cpu/rise.c 2006-03-19 23:53:29.000000000 -0600
+++ linux-2.6.16/arch/i386/kernel/cpu/rise.c 2006-06-09 18:45:17.000000000 -0500
@@ -7,9 +7,9 @@
static void __init init_rise(struct cpuinfo_x86 *c)
{
- printk("CPU: Rise iDragon");
+ printk(KERN_INFO "CPU: Rise iDragon");
if (c->x86_model > 2)
- printk(" II");
+ printk(KERN_INFO " II");
printk("\n");
/* Unhide possibly hidden capability flags
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [KJ] [PATCH] Add KERN constants to arch/i386/kernel/cpu/rise.c
2006-06-11 23:13 [KJ] [PATCH] Add KERN constants to arch/i386/kernel/cpu/rise.c Matthew Martin
@ 2006-06-11 23:30 ` Dave Jones
2006-06-12 3:01 ` Randy.Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jones @ 2006-06-11 23:30 UTC (permalink / raw)
To: kernel-janitors
On Sun, Jun 11, 2006 at 06:13:16PM -0500, Matthew Martin wrote:
> Hello,
> This adds KERN constants to arch/i386/kernel/cpu/rise.c
>
> Signed-Off-By: Matthew Martin <lihnucks@gmail.com>
> ---
>
>
> --- vanilla-linux-2.6.16/arch/i386/kernel/cpu/rise.c 2006-03-19 23:53:29.000000000 -0600
> +++ linux-2.6.16/arch/i386/kernel/cpu/rise.c 2006-06-09 18:45:17.000000000 -0500
> @@ -7,9 +7,9 @@
>
> static void __init init_rise(struct cpuinfo_x86 *c)
> {
> - printk("CPU: Rise iDragon");
> + printk(KERN_INFO "CPU: Rise iDragon");
> if (c->x86_model > 2)
> - printk(" II");
> + printk(KERN_INFO " II");
> printk("\n");
Note that there's no \n on the first printk. This means that adding teh KERN_INFO
to the second printk is incorrect, as it'll result in output like..
CPU: Rise iDragon<6> II
Dave
--
http://www.codemonkey.org.uk
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [KJ] [PATCH] Add KERN constants to arch/i386/kernel/cpu/rise.c
2006-06-11 23:13 [KJ] [PATCH] Add KERN constants to arch/i386/kernel/cpu/rise.c Matthew Martin
2006-06-11 23:30 ` Dave Jones
@ 2006-06-12 3:01 ` Randy.Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Randy.Dunlap @ 2006-06-12 3:01 UTC (permalink / raw)
To: kernel-janitors
On Sun, 11 Jun 2006 19:30:34 -0400 Dave Jones wrote:
> On Sun, Jun 11, 2006 at 06:13:16PM -0500, Matthew Martin wrote:
> > Hello,
> > This adds KERN constants to arch/i386/kernel/cpu/rise.c
> >
> > Signed-Off-By: Matthew Martin <lihnucks@gmail.com>
> > ---
> >
> >
> > --- vanilla-linux-2.6.16/arch/i386/kernel/cpu/rise.c 2006-03-19 23:53:29.000000000 -0600
> > +++ linux-2.6.16/arch/i386/kernel/cpu/rise.c 2006-06-09 18:45:17.000000000 -0500
> > @@ -7,9 +7,9 @@
> >
> > static void __init init_rise(struct cpuinfo_x86 *c)
> > {
> > - printk("CPU: Rise iDragon");
> > + printk(KERN_INFO "CPU: Rise iDragon");
> > if (c->x86_model > 2)
> > - printk(" II");
> > + printk(KERN_INFO " II");
> > printk("\n");
>
> Note that there's no \n on the first printk. This means that adding teh KERN_INFO
> to the second printk is incorrect, as it'll result in output like..
>
> CPU: Rise iDragon<6> II
which is why the KJ TODO says:
- printk() calls should include appropriate KERN_* constant (of course
only at beginning of lines).
---
~Randy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-06-12 3:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-11 23:13 [KJ] [PATCH] Add KERN constants to arch/i386/kernel/cpu/rise.c Matthew Martin
2006-06-11 23:30 ` Dave Jones
2006-06-12 3:01 ` Randy.Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.