From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [tytso@thunk.org: [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private]
Date: Mon, 19 Jun 2006 08:48:05 -0700 [thread overview]
Message-ID: <20060619154805.GP29684@ca-server1.us.oracle.com> (raw)
Folks,
Here in Ted's inode-diet patch, he renames inode->u.generic_ip
to inode->i_private. I note that OCFS2 uses generic_ip only one place,
in debug code:
ocfs2_dlm_debug_open():
1998 osb = (struct ocfs2_super *) inode->u.generic_ip;
However, we never set it! This leads me to believe this is stale code.
Thoughts.
Joel
--
"Only a life lived for others is a life worth while."
-Albert Einstein
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
-------------- next part --------------
An embedded message was scrubbed...
From: Theodore Tso <tytso@thunk.org>
Subject: [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with
inode.i_private
Date: Mon, 19 Jun 2006 11:20:04 -0400
Size: 34762
Url: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20060619/1da41851/attachment-0001.mht
next reply other threads:[~2006-06-19 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-19 15:48 Joel Becker [this message]
2006-06-19 19:39 ` [Ocfs2-devel] [tytso@thunk.org: [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private] Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060619154805.GP29684@ca-server1.us.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.