From: Zach Brown <zach.brown@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [tytso@thunk.org: [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private]
Date: Mon, 19 Jun 2006 12:39:26 -0700 [thread overview]
Message-ID: <4496FD6E.4020902@oracle.com> (raw)
In-Reply-To: <20060619154805.GP29684@ca-server1.us.oracle.com>
> I note that OCFS2 uses generic_ip only one place, in debug code:
>
> ocfs2_dlm_debug_open():
> 1998 osb = (struct ocfs2_super *) inode->u.generic_ip;
>
> However, we never set it! This leads me to believe this is stale code.
That's the dlm debugging fops getting the osb off of the debugfs inode's
generic_ip which was set with debugfs_create_file().
- z
prev parent reply other threads:[~2006-06-19 19:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-19 15:48 [Ocfs2-devel] [tytso@thunk.org: [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private] Joel Becker
2006-06-19 19:39 ` Zach Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4496FD6E.4020902@oracle.com \
--to=zach.brown@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.