All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>,
	David Howells <dhowells@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Christoph Lameter <christoph@lameter.com>,
	Martin Bligh <mbligh@google.com>, Nick Piggin <npiggin@suse.de>,
	Linus Torvalds <torvalds@osdl.org>
Subject: [PATCH 6/6] mm: remove some update_mmu_cache() calls
Date: Mon, 19 Jun 2006 19:53:47 +0200	[thread overview]
Message-ID: <20060619175347.24655.67680.sendpatchset@lappy> (raw)
In-Reply-To: <20060619175243.24655.76005.sendpatchset@lappy>


From: Christoph Lameter <clameter@sgi.com>

This may be a bit controversial but it does not seem to
make sense to use the update_mmu_cache macro when we reuse
the page. We are only fiddling around with the protections,
the dirty and accessed bits.

With the call to update_mmu_cache the way of using the macros
would be different from mprotect() and page_mkclean(). I'd
rather have everything work the same way. If this breaks on some
arches then also mprotect and page_mkclean() are broken.
The use of mprotect() is rare, we may have breakage in some
arches that we just have not seen yet.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
 mm/memory.c |    2 --
 1 file changed, 2 deletions(-)

Index: 2.6-mm/mm/memory.c
===================================================================
--- 2.6-mm.orig/mm/memory.c	2006-06-19 16:21:16.000000000 +0200
+++ 2.6-mm/mm/memory.c	2006-06-19 16:21:25.000000000 +0200
@@ -1514,7 +1514,6 @@ static int do_wp_page(struct mm_struct *
 		entry = pte_mkyoung(orig_pte);
 		entry = maybe_mkwrite(pte_mkdirty(entry), vma);
 		ptep_set_access_flags(vma, address, page_table, entry, 1);
-		update_mmu_cache(vma, address, entry);
 		lazy_mmu_prot_update(entry);
 		ret |= VM_FAULT_WRITE;
 		goto unlock;
@@ -2317,7 +2316,6 @@ static inline int handle_pte_fault(struc
 	entry = pte_mkyoung(entry);
 	if (!pte_same(old_entry, entry)) {
 		ptep_set_access_flags(vma, address, pte, entry, write_access);
-		update_mmu_cache(vma, address, entry);
 		lazy_mmu_prot_update(entry);
 	} else {
 		/*

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>,
	David Howells <dhowells@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Christoph Lameter <christoph@lameter.com>,
	Martin Bligh <mbligh@google.com>, Nick Piggin <npiggin@suse.de>,
	Linus Torvalds <torvalds@osdl.org>
Subject: [PATCH 6/6] mm: remove some update_mmu_cache() calls
Date: Mon, 19 Jun 2006 19:53:47 +0200	[thread overview]
Message-ID: <20060619175347.24655.67680.sendpatchset@lappy> (raw)
In-Reply-To: <20060619175243.24655.76005.sendpatchset@lappy>

From: Christoph Lameter <clameter@sgi.com>

This may be a bit controversial but it does not seem to
make sense to use the update_mmu_cache macro when we reuse
the page. We are only fiddling around with the protections,
the dirty and accessed bits.

With the call to update_mmu_cache the way of using the macros
would be different from mprotect() and page_mkclean(). I'd
rather have everything work the same way. If this breaks on some
arches then also mprotect and page_mkclean() are broken.
The use of mprotect() is rare, we may have breakage in some
arches that we just have not seen yet.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
 mm/memory.c |    2 --
 1 file changed, 2 deletions(-)

Index: 2.6-mm/mm/memory.c
===================================================================
--- 2.6-mm.orig/mm/memory.c	2006-06-19 16:21:16.000000000 +0200
+++ 2.6-mm/mm/memory.c	2006-06-19 16:21:25.000000000 +0200
@@ -1514,7 +1514,6 @@ static int do_wp_page(struct mm_struct *
 		entry = pte_mkyoung(orig_pte);
 		entry = maybe_mkwrite(pte_mkdirty(entry), vma);
 		ptep_set_access_flags(vma, address, page_table, entry, 1);
-		update_mmu_cache(vma, address, entry);
 		lazy_mmu_prot_update(entry);
 		ret |= VM_FAULT_WRITE;
 		goto unlock;
@@ -2317,7 +2316,6 @@ static inline int handle_pte_fault(struc
 	entry = pte_mkyoung(entry);
 	if (!pte_same(old_entry, entry)) {
 		ptep_set_access_flags(vma, address, pte, entry, write_access);
-		update_mmu_cache(vma, address, entry);
 		lazy_mmu_prot_update(entry);
 	} else {
 		/*

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2006-06-19 17:54 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-19 17:52 [PATCH 0/6] mm: tracking dirty pages -v9 Peter Zijlstra
2006-06-19 17:52 ` Peter Zijlstra
2006-06-19 17:52 ` [PATCH 1/6] mm: tracking shared dirty pages Peter Zijlstra
2006-06-19 17:52   ` Peter Zijlstra
2006-06-22  5:56   ` Andrew Morton
2006-06-22  5:56     ` Andrew Morton
2006-06-22  6:07     ` Christoph Lameter
2006-06-22  6:07       ` Christoph Lameter
2006-06-22  6:15       ` Andrew Morton
2006-06-22  6:15         ` Andrew Morton
2006-06-22 11:33     ` Peter Zijlstra
2006-06-22 11:33       ` Peter Zijlstra
2006-06-22 13:17       ` Hugh Dickins
2006-06-22 13:17         ` Hugh Dickins
2006-06-22 20:52   ` Hugh Dickins
2006-06-22 20:52     ` Hugh Dickins
2006-06-22 23:02     ` Peter Zijlstra
2006-06-22 23:02       ` Peter Zijlstra
2006-06-22 23:39     ` [PATCH] mm: tracking shared dirty pages -v10 Peter Zijlstra
2006-06-22 23:39       ` Peter Zijlstra
2006-06-23  3:10       ` Jeff Dike
2006-06-23  3:10         ` Jeff Dike
2006-06-23  3:31         ` Andrew Morton
2006-06-23  3:31           ` Andrew Morton
2006-06-23  3:50           ` Jeff Dike
2006-06-23  3:50             ` Jeff Dike
2006-06-23  4:01           ` H. Peter Anvin
2006-06-23  4:01             ` H. Peter Anvin
2006-06-23 15:08             ` Jeff Dike
2006-06-23 15:08               ` Jeff Dike
2006-06-23  6:08       ` Linus Torvalds
2006-06-23  6:08         ` Linus Torvalds
2006-06-23  7:27         ` Hugh Dickins
2006-06-23  7:27           ` Hugh Dickins
2006-06-23 17:00           ` Christoph Lameter
2006-06-23 17:00             ` Christoph Lameter
2006-06-23 17:22             ` Peter Zijlstra
2006-06-23 17:22               ` Peter Zijlstra
2006-06-23 17:52               ` Christoph Lameter
2006-06-23 17:52                 ` Christoph Lameter
2006-06-23 18:11                 ` Martin Bligh
2006-06-23 18:11                   ` Martin Bligh
2006-06-23 18:20                   ` Linus Torvalds
2006-06-23 18:20                     ` Linus Torvalds
2006-06-23 17:56               ` Linus Torvalds
2006-06-23 17:56                 ` Linus Torvalds
2006-06-23 18:03                 ` Peter Zijlstra
2006-06-23 18:03                   ` Peter Zijlstra
2006-06-23 18:23                   ` Christoph Lameter
2006-06-23 18:23                     ` Christoph Lameter
2006-06-23 18:41                 ` Christoph Hellwig
2006-06-23 18:41                   ` Christoph Hellwig
2006-06-23 17:49           ` Linus Torvalds
2006-06-23 17:49             ` Linus Torvalds
2006-06-23 18:05             ` Arjan van de Ven
2006-06-23 18:05               ` Arjan van de Ven
2006-06-23 18:08             ` Miklos Szeredi
2006-06-23 18:08               ` Miklos Szeredi
2006-06-23 19:06       ` Hugh Dickins
2006-06-23 19:06         ` Hugh Dickins
2006-06-23 22:00         ` Peter Zijlstra
2006-06-23 22:00           ` Peter Zijlstra
2006-06-23 22:35           ` Linus Torvalds
2006-06-23 22:35             ` Linus Torvalds
2006-06-23 22:44             ` Peter Zijlstra
2006-06-23 22:44               ` Peter Zijlstra
2006-06-28 14:58         ` [RFC][PATCH] mm: fixup do_wp_page() Peter Zijlstra
2006-06-28 14:58           ` Peter Zijlstra
2006-06-28 18:20           ` Hugh Dickins
2006-06-28 18:20             ` Hugh Dickins
2006-06-19 17:53 ` [PATCH 2/6] mm: balance dirty pages Peter Zijlstra
2006-06-19 17:53   ` Peter Zijlstra
2006-06-19 17:53 ` [PATCH 3/6] mm: msync() cleanup Peter Zijlstra
2006-06-19 17:53   ` Peter Zijlstra
2006-06-22 17:02   ` Hugh Dickins
2006-06-22 17:02     ` Hugh Dickins
2006-06-19 17:53 ` [PATCH 4/6] mm: optimize the new mprotect() code a bit Peter Zijlstra
2006-06-19 17:53   ` Peter Zijlstra
2006-06-22 17:21   ` Hugh Dickins
2006-06-22 17:21     ` Hugh Dickins
2006-06-19 17:53 ` [PATCH 5/6] mm: small cleanup of install_page() Peter Zijlstra
2006-06-19 17:53   ` Peter Zijlstra
2006-06-19 17:53 ` Peter Zijlstra [this message]
2006-06-19 17:53   ` [PATCH 6/6] mm: remove some update_mmu_cache() calls Peter Zijlstra
2006-06-22 16:29   ` Hugh Dickins
2006-06-22 16:29     ` Hugh Dickins
2006-06-22 16:37     ` Christoph Lameter
2006-06-22 16:37       ` Christoph Lameter
2006-06-22 17:35       ` Hugh Dickins
2006-06-22 17:35         ` Hugh Dickins
2006-06-22 18:31         ` Christoph Lameter
2006-06-22 18:31           ` Christoph Lameter
  -- strict thread matches above, loose matches on Subject: below --
2006-06-13 11:21 [PATCH 0/6] mm: tracking dirty pages -v8 Peter Zijlstra
2006-06-13 11:22 ` [PATCH 6/6] mm: remove some update_mmu_cache() calls Peter Zijlstra
2006-06-13 11:22   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060619175347.24655.67680.sendpatchset@lappy \
    --to=a.p.zijlstra@chello.nl \
    --cc=akpm@osdl.org \
    --cc=christoph@lameter.com \
    --cc=dhowells@redhat.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mbligh@google.com \
    --cc=npiggin@suse.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.