From: Mark Fasheh <mark.fasheh@oracle.com>
To: Andrew Morton <akpm@osdl.org>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [-mm PATCH] ocfs2: Shared writeable mmap
Date: Mon, 19 Jun 2006 17:52:24 -0700 [thread overview]
Message-ID: <20060620005224.GL3082@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20060619170736.65237ce7.akpm@osdl.org>
On Mon, Jun 19, 2006 at 05:07:36PM -0700, Andrew Morton wrote:
> The thing is that get_user_pages(.write=1, .force=1) can generate COW
> hits on read-only shared mappings, this patch traps those as mkpage_write
> candidates and fails to handle them the old way.
Ahh ok. Too bad this doesn't seem like it could be causing my bug :( Can I
ask what the old way of handling this is?
> It would be better to get a fix against the existing
> add-page_mkwrite-vm_operations-method.patch so at least we can get that
> merged up. But nobody seems to be offering that.
Were I capable, I'd certainly offer up a patch :/ Definitely though, I agree
that sorting this out first seems like a reasonable way to go.
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh at oracle.com
WARNING: multiple messages have this Message-ID (diff)
From: Mark Fasheh <mark.fasheh@oracle.com>
To: Andrew Morton <akpm@osdl.org>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
ocfs2-devel@oss.oracle.com
Subject: Re: [-mm PATCH] ocfs2: Shared writeable mmap
Date: Mon, 19 Jun 2006 17:52:24 -0700 [thread overview]
Message-ID: <20060620005224.GL3082@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20060619170736.65237ce7.akpm@osdl.org>
On Mon, Jun 19, 2006 at 05:07:36PM -0700, Andrew Morton wrote:
> The thing is that get_user_pages(.write=1, .force=1) can generate COW
> hits on read-only shared mappings, this patch traps those as mkpage_write
> candidates and fails to handle them the old way.
Ahh ok. Too bad this doesn't seem like it could be causing my bug :( Can I
ask what the old way of handling this is?
> It would be better to get a fix against the existing
> add-page_mkwrite-vm_operations-method.patch so at least we can get that
> merged up. But nobody seems to be offering that.
Were I capable, I'd certainly offer up a patch :/ Definitely though, I agree
that sorting this out first seems like a reasonable way to go.
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com
next prev parent reply other threads:[~2006-06-20 0:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-19 23:46 [Ocfs2-devel] [-mm PATCH] ocfs2: Shared writeable mmap Mark Fasheh
2006-06-19 23:46 ` Mark Fasheh
2006-06-19 23:55 ` [Ocfs2-devel] " Daniel Phillips
2006-06-19 23:55 ` Daniel Phillips
2006-06-20 5:42 ` Mark Fasheh
2006-06-20 5:42 ` Mark Fasheh
2006-06-20 0:07 ` [Ocfs2-devel] " Andrew Morton
2006-06-20 0:07 ` Andrew Morton
2006-06-20 0:52 ` Mark Fasheh [this message]
2006-06-20 0:52 ` Mark Fasheh
2006-06-20 7:07 ` [Ocfs2-devel] " Peter Zijlstra
2006-06-20 7:07 ` Peter Zijlstra
2006-06-20 12:59 ` [Ocfs2-devel] " David Howells
2006-06-20 12:59 ` David Howells
2006-06-20 13:02 ` [Ocfs2-devel] " David Howells
2006-06-20 13:02 ` David Howells
2006-06-20 13:20 ` [Ocfs2-devel] [PATCH] Add notification of page becoming writable to VMA ops David Howells
2006-06-20 13:20 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060620005224.GL3082@ca-server1.us.oracle.com \
--to=mark.fasheh@oracle.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.