All of lore.kernel.org
 help / color / mirror / Atom feed
* [KJ] [PATCH] Add missing printk() log-level constants in
@ 2006-06-21  1:27 Julius Volz
  2006-06-21  5:36 ` Domen Puncer
  2006-06-21  6:44 ` Julius Volz
  0 siblings, 2 replies; 3+ messages in thread
From: Julius Volz @ 2006-06-21  1:27 UTC (permalink / raw)
  To: kernel-janitors

Hi,

with my second patch I'll try adding some printk() log-level constants.
Please enlighten me about any mistakes I might have made and whether
the log-levels I chose seem appropriate...

Description:
This patch adds some missing printk() log-level constants in
drivers/acpi/pci_link.c.

Signed-Off-By: Julius Volz <juliusrv@gmail.com>

--- pci_link.c.orig	2006-06-21 02:39:27.000000000 +0200
+++ pci_link.c	2006-06-21 03:19:39.000000000 +0200
@@ -361,7 +361,7 @@
 		/* ignore resource_source, it's optional */
 		break;
 	default:
-		printk("ACPI BUG: resource_type %d\n", link->irq.resource_type);
+		printk(KERN_WARNING "ACPI BUG: resource_type %d\n", link->irq.resource_type);
 		result = -EINVAL;
 		goto end;
 
@@ -588,15 +588,15 @@
 
 	/* Attempt to enable the link device at this IRQ. */
 	if (acpi_pci_link_set(link, irq)) {
-		printk(PREFIX
+		printk(KERN_WARNING PREFIX
 		       "Unable to set IRQ for %s [%s] (likely buggy ACPI BIOS).\n"
-		       "Try pci=noacpi or acpi=off\n",
+		       KERN_WARNING PREFIX "Try pci=noacpi or acpi=off\n",
 		       acpi_device_name(link->device),
 		       acpi_device_bid(link->device));
 		return_VALUE(-ENODEV);
 	} else {
 		acpi_irq_penalty[link->irq.active] += PIRQ_PENALTY_PCI_USING;
-		printk(PREFIX "%s [%s] enabled at IRQ %d\n",
+		printk(KERN_INFO PREFIX "%s [%s] enabled at IRQ %d\n",
 		       acpi_device_name(link->device),
 		       acpi_device_bid(link->device), link->irq.active);
 	}
@@ -755,7 +755,7 @@
 	/* query and set link->irq.active */
 	acpi_pci_link_get_current(link);
 
-	printk(PREFIX "%s [%s] (IRQs", acpi_device_name(device),
+	printk(KERN_INFO PREFIX "%s [%s] (IRQs", acpi_device_name(device),
 	       acpi_device_bid(device));
 	for (i = 0; i < link->irq.possible_count; i++) {
 		if (link->irq.active = link->irq.possible[i]) {
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [KJ] [PATCH] Add missing printk() log-level constants in
  2006-06-21  1:27 [KJ] [PATCH] Add missing printk() log-level constants in Julius Volz
@ 2006-06-21  5:36 ` Domen Puncer
  2006-06-21  6:44 ` Julius Volz
  1 sibling, 0 replies; 3+ messages in thread
From: Domen Puncer @ 2006-06-21  5:36 UTC (permalink / raw)
  To: kernel-janitors

On 21/06/06 03:27 +0200, Julius Volz wrote:
> Hi,
> 
> with my second patch I'll try adding some printk() log-level constants.
> Please enlighten me about any mistakes I might have made and whether
> the log-levels I chose seem appropriate...
> 
> Description:
> This patch adds some missing printk() log-level constants in
> drivers/acpi/pci_link.c.
> 
> Signed-Off-By: Julius Volz <juliusrv@gmail.com>
> 
> --- pci_link.c.orig	2006-06-21 02:39:27.000000000 +0200
> +++ pci_link.c	2006-06-21 03:19:39.000000000 +0200

Not a -p1 appliable patch (just send it to yourself, and try
to patch -p1 -i your_email when in kernel source dir).

Other than this it looks fine to me.


	Domen
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [KJ] [PATCH] Add missing printk() log-level constants in
  2006-06-21  1:27 [KJ] [PATCH] Add missing printk() log-level constants in Julius Volz
  2006-06-21  5:36 ` Domen Puncer
@ 2006-06-21  6:44 ` Julius Volz
  1 sibling, 0 replies; 3+ messages in thread
From: Julius Volz @ 2006-06-21  6:44 UTC (permalink / raw)
  To: kernel-janitors

Domen Puncer wrote:
> Not a -p1 appliable patch (just send it to yourself, and try
> to patch -p1 -i your_email when in kernel source dir).

Ah, right. Here is the corrected version:

Description:
This patch adds some missing printk() log-level constants in
drivers/acpi/pci_link.c.

Signed-Off-By: Julius Volz <juliusrv@gmail.com>

--- linux-2.6.17/drivers/acpi/pci_link.c.orig	2006-06-21 02:39:27.000000000 +0200
+++ linux-2.6.17/drivers/acpi/pci_link.c	2006-06-21 03:19:39.000000000 +0200
@@ -361,7 +361,7 @@ static int acpi_pci_link_set(struct acpi
 		/* ignore resource_source, it's optional */
 		break;
 	default:
-		printk("ACPI BUG: resource_type %d\n", link->irq.resource_type);
+		printk(KERN_WARNING "ACPI BUG: resource_type %d\n", link->irq.resource_type);
 		result = -EINVAL;
 		goto end;
 
@@ -588,15 +588,15 @@ static int acpi_pci_link_allocate(struct
 
 	/* Attempt to enable the link device at this IRQ. */
 	if (acpi_pci_link_set(link, irq)) {
-		printk(PREFIX
+		printk(KERN_WARNING PREFIX
 		       "Unable to set IRQ for %s [%s] (likely buggy ACPI BIOS).\n"
-		       "Try pci=noacpi or acpi=off\n",
+		       KERN_WARNING PREFIX "Try pci=noacpi or acpi=off\n",
 		       acpi_device_name(link->device),
 		       acpi_device_bid(link->device));
 		return_VALUE(-ENODEV);
 	} else {
 		acpi_irq_penalty[link->irq.active] += PIRQ_PENALTY_PCI_USING;
-		printk(PREFIX "%s [%s] enabled at IRQ %d\n",
+		printk(KERN_INFO PREFIX "%s [%s] enabled at IRQ %d\n",
 		       acpi_device_name(link->device),
 		       acpi_device_bid(link->device), link->irq.active);
 	}
@@ -755,7 +755,7 @@ static int acpi_pci_link_add(struct acpi
 	/* query and set link->irq.active */
 	acpi_pci_link_get_current(link);
 
-	printk(PREFIX "%s [%s] (IRQs", acpi_device_name(device),
+	printk(KERN_INFO PREFIX "%s [%s] (IRQs", acpi_device_name(device),
 	       acpi_device_bid(device));
 	for (i = 0; i < link->irq.possible_count; i++) {
 		if (link->irq.active = link->irq.possible[i]) {
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-06-21  6:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-21  1:27 [KJ] [PATCH] Add missing printk() log-level constants in Julius Volz
2006-06-21  5:36 ` Domen Puncer
2006-06-21  6:44 ` Julius Volz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.